Deprecate assigns() and assert_template following #18950. - #19058
Closed
alex-grover wants to merge 2 commits into
Closed
Deprecate assigns() and assert_template following #18950.#19058alex-grover wants to merge 2 commits into
alex-grover wants to merge 2 commits into
Conversation
Member
|
The tests are failing. Also we need to remove/suppress tests related to these. |
Author
|
There are hundreds of tests that use these functions - I am assuming that the desired outcome is that they be rewritten to use different testing logic. I rewrote the single failing test to pass (not sure if the way I did it was too hacky) but I don't have the capacity to rewrite them all myself. Let me know what you think should be done. |
Author
|
@vipulnsward: @bgott and I can start taking a look at these if you think that rewriting the tests using assigns and assert_template is desired. Let us know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.