New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate assigns() and assert_template following #18950. #19058

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@ajgrover
Contributor

ajgrover commented Feb 24, 2015

No description provided.

@vipulnsward

This comment has been minimized.

Show comment
Hide comment
@vipulnsward

vipulnsward Feb 24, 2015

Member

The tests are failing. Also we need to remove/suppress tests related to these.

Member

vipulnsward commented Feb 24, 2015

The tests are failing. Also we need to remove/suppress tests related to these.

@ajgrover

This comment has been minimized.

Show comment
Hide comment
@ajgrover

ajgrover Feb 24, 2015

Contributor

There are hundreds of tests that use these functions - I am assuming that the desired outcome is that they be rewritten to use different testing logic. I rewrote the single failing test to pass (not sure if the way I did it was too hacky) but I don't have the capacity to rewrite them all myself. Let me know what you think should be done.

Contributor

ajgrover commented Feb 24, 2015

There are hundreds of tests that use these functions - I am assuming that the desired outcome is that they be rewritten to use different testing logic. I rewrote the single failing test to pass (not sure if the way I did it was too hacky) but I don't have the capacity to rewrite them all myself. Let me know what you think should be done.

@ajgrover

This comment has been minimized.

Show comment
Hide comment
@ajgrover

ajgrover Mar 3, 2015

Contributor

@vipulnsward: @bgott and I can start taking a look at these if you think that rewriting the tests using assigns and assert_template is desired. Let us know.

Contributor

ajgrover commented Mar 3, 2015

@vipulnsward: @bgott and I can start taking a look at these if you think that rewriting the tests using assigns and assert_template is desired. Let us know.

@ajgrover ajgrover closed this Sep 2, 2015

@ajgrover ajgrover deleted the ajgrover:add_deprecation_warnings branch Sep 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment