Deprecate `AbstractController::Callbacks#skip_action_callback` #19060

Merged
merged 1 commit into from Feb 24, 2015

Conversation

Projects
None yet
2 participants
@iainbeeston
Contributor

iainbeeston commented Feb 24, 2015

As part of #19029, in future skip_before_action, skip_after_action and
skip_around_action will raise an ArgumentError if the specified
callback does not exist. skip_action_callback calls all three of these
methods and will almost certainly result in an ArgumentError. If anyone
wants to remove all three callbacks then they can still call the three
individual methods. Therefore let's deprecate skip_action_callback now
and remove it when #19029 is merged.

Deprecate `AbstractController::Callbacks#skip_action_callback`
As part of #19029, in future `skip_before_action`, `skip_after_action` and
`skip_around_action` will raise an ArgumentError if the specified
callback does not exist. `skip_action_callback` calls all three of these
methods and will almost certainly result in an ArgumentError. If anyone
wants to remove all three callbacks then they can still call the three
individual methods. Therefore let's deprecate `skip_action_callback` now
and remove it when #19029 is merged.

rafaelfranca added a commit that referenced this pull request Feb 24, 2015

Merge pull request #19060 from iainbeeston/deprecate-skip-action-call…
…back

Deprecate `AbstractController::Callbacks#skip_action_callback`

@rafaelfranca rafaelfranca merged commit 6976e1d into rails:master Feb 24, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

JoeCohen added a commit to MushroomObserver/mushroom-observer that referenced this pull request Aug 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment