Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate AbstractController::Callbacks#skip_action_callback #19060

Merged

Conversation

iainbeeston
Copy link
Contributor

@iainbeeston iainbeeston commented Feb 24, 2015

As part of #19029, in future skip_before_action, skip_after_action and
skip_around_action will raise an ArgumentError if the specified
callback does not exist. skip_action_callback calls all three of these
methods and will almost certainly result in an ArgumentError. If anyone
wants to remove all three callbacks then they can still call the three
individual methods. Therefore let's deprecate skip_action_callback now
and remove it when #19029 is merged.

As part of rails#19029, in future `skip_before_action`, `skip_after_action` and
`skip_around_action` will raise an ArgumentError if the specified
callback does not exist. `skip_action_callback` calls all three of these
methods and will almost certainly result in an ArgumentError. If anyone
wants to remove all three callbacks then they can still call the three
individual methods. Therefore let's deprecate `skip_action_callback` now
and remove it when rails#19029 is merged.
rafaelfranca added a commit that referenced this pull request Feb 24, 2015
…back

Deprecate `AbstractController::Callbacks#skip_action_callback`
@rafaelfranca rafaelfranca merged commit 6976e1d into rails:master Feb 24, 2015
JoeCohen added a commit to MushroomObserver/mushroom-observer that referenced this pull request Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants