Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mysql's schema.rb dumper so it does not include limit on emulated booleans #19066

Merged
merged 1 commit into from Feb 24, 2015

Conversation

@courtenay
Copy link
Contributor

courtenay commented Feb 24, 2015

See issue #19065

… boolean tinyint(1) fields
rafaelfranca added a commit that referenced this pull request Feb 24, 2015
Fix mysql's schema.rb dumper so it does not include limit on emulated booleans
@rafaelfranca rafaelfranca merged commit 2bc72ae into rails:master Feb 24, 2015
rafaelfranca added a commit that referenced this pull request Feb 24, 2015
Fix mysql's schema.rb dumper so it does not include limit on emulated booleans
@rafaelfranca

This comment has been minimized.

Copy link
Member

rafaelfranca commented Feb 24, 2015

Backported as 36fa6f9

pixeltrix added a commit to alphagov/e-petitions that referenced this pull request May 5, 2015
Some tweaks were needed to the schema.rb file because of duplicate index
names and a issue with a `limit: 1` being added to boolean columns - for
further information see rails/rails#19066[1].

[1]: rails/rails#19066
pixeltrix added a commit to alphagov/e-petitions that referenced this pull request May 5, 2015
Some tweaks were needed to the schema.rb file because of duplicate index
names and a issue with a `limit: 1` being added to boolean columns - for
further information see rails/rails#19066[1].

[1]: rails/rails#19066
benlovell added a commit to alphagov/whitehall that referenced this pull request Feb 2, 2016
Adds `Classification#content_id` attribute and ensures placeholder
content is published upon creation.

A bunch of unrelated things were modified in `schema.rb` due to changes
in Rails' generation of `boolean` columns. See: rails/rails#19066 [1]

[1] rails/rails#19066
benlovell added a commit to alphagov/whitehall that referenced this pull request Feb 2, 2016
Adds `Classification#content_id` attribute and ensures placeholder
content is published upon creation.

A bunch of unrelated things were modified in `schema.rb` due to changes
in Rails' generation of `boolean` columns. See: rails/rails#19066 [1]

[1] rails/rails#19066
benlovell added a commit to alphagov/whitehall that referenced this pull request Feb 2, 2016
Since a recent Rails upgrade (`> 4.2.2`) included rails/rails#19066 [1],
and running a migration in an ongoing PR produced these incidental
changes, we decided offline to highlight them in a separate commit and
subsequent PR.

[1] rails/rails#19066
benlovell added a commit to alphagov/whitehall that referenced this pull request Feb 2, 2016
Since a recent Rails upgrade (`> 4.2.2`) included rails/rails#19066 [1],
and running a migration in an ongoing PR produced these incidental
changes, we decided offline to highlight them in a separate commit and
subsequent PR.

[1] rails/rails#19066
benlovell added a commit to alphagov/whitehall that referenced this pull request Feb 2, 2016
Adds `Classification#content_id` attribute and ensures placeholder
content is published upon creation.

A bunch of unrelated things were modified in `schema.rb` due to changes
in Rails' generation of `boolean` columns. See: rails/rails#19066 [1]

[1] rails/rails#19066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.