[ci skip] Update documentation for Range#to_formatted_s

[davydovanton]

Added information about default :db format and added information about custom formats 🎉

[kaspth]

I don't think we should tell people to replace and break the RANGE_FORMATS, but extend it. Instead your example could be Range::RANGE_FORMATS[:example] = ->(start, stop) { ... }.

[davydovanton]

@kaspth yes, you're right, thanks! ❤️

[davydovanton]

@kaspth fixed this

[kaspth]

I'd love it if we could make the documentation here more consistent with Date's to_formatted_s:

rails/activesupport/lib/active_support/core_ext/date/conversions.rb

Lines 28 to 51 in afc98ea

	# Convert to a formatted string. See DATE_FORMATS for predefined formats.
	#
	# This method is aliased to <tt>to_s</tt>.
	#
	# date = Date.new(2007, 11, 10) # => Sat, 10 Nov 2007
	#
	# date.to_formatted_s(:db) # => "2007-11-10"
	# date.to_s(:db) # => "2007-11-10"
	#
	# date.to_formatted_s(:short) # => "10 Nov"
	# date.to_formatted_s(:long) # => "November 10, 2007"
	# date.to_formatted_s(:long_ordinal) # => "November 10th, 2007"
	# date.to_formatted_s(:rfc822) # => "10 Nov 2007"
	# date.to_formatted_s(:iso8601) # => "2007-11-10"
	#
	# == Adding your own date formats to to_formatted_s
	# You can add your own formats to the Date::DATE_FORMATS hash.
	# Use the format name as the hash key and either a strftime string
	# or Proc instance that takes a date argument as the value.
	#
	# # config/initializers/date_formats.rb
	# Date::DATE_FORMATS[:month_and_year] = '%B %Y'
	# Date::DATE_FORMATS[:short_ordinal] = ->(date) { date.strftime("%B #{date.day.ordinalize}") }
	def to_formatted_s(format = :default)

❤️

[davydovanton]

@kaspth fixed this too 😃

[kaspth]

Remove a: that takes a start and stop arguments as the value.

[kaspth]

✂️ either

[kaspth]

Let's use a more real example, like:

Range::RANGE_FORMATS[:short] = ->(start, stop) { "Between #{start.to_s(:short)} and #{stop.to_s(:short)}" }

[davydovanton]

@kaspth fixed all. Thanks for review! 💚 💛 ❤️

[kaspth]

No problem, 👍. The documentation here is way better because of your work ❤️

[kaspth]

Holy crap! You got the 50000th commit to Rails 😉

[davydovanton]

WOW! 🎉 thanks! 🌟

[vipulnsward]

🎉