Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rake restart task no longer loads entire Rails environment when run #19169

Merged
merged 1 commit into from Mar 2, 2015

Conversation

@hjoo
Copy link
Contributor

@hjoo hjoo commented Mar 2, 2015

Fixes #18876. Rake restart touches tmp/restart.txt to restart
application on next request. Updated test and documentation accordingly.

@arthurnn
Copy link
Member

@arthurnn arthurnn commented Mar 2, 2015

:shipit:

@eileencodes
Copy link
Member

@eileencodes eileencodes commented Mar 2, 2015

Probably not going to affect it but I'm waiting til CI finishes to merge 😁

@kaspth
Copy link
Member

@kaspth kaspth commented Mar 2, 2015

@hjoo your commit message is off as you've already added the rake task. Can you update your commit message to say the task no longer loads the whole Rails environment when run 😄

If you can, a quick explanation of why the task doesn't need the environment would be great too 👍

The restart task does not need access to models or other classes and
helpers from the application environment.
@hjoo hjoo force-pushed the hjoo:rake_restart branch to beaf8cb Mar 2, 2015
@hjoo
Copy link
Contributor Author

@hjoo hjoo commented Mar 2, 2015

Oops, fixed it! Thanks for the feedback. 👍

eileencodes added a commit that referenced this pull request Mar 2, 2015
Rake restart task no longer loads entire Rails environment when run
@eileencodes eileencodes merged commit 230393a into rails:master Mar 2, 2015
@kaspth
Copy link
Member

@kaspth kaspth commented Mar 2, 2015

Well done 👍

@waynerobinson
Copy link

@waynerobinson waynerobinson commented Mar 23, 2015

Shouldn't this also be rails restart to go with the style of #18878?

@olivierlacan
Copy link
Contributor

@olivierlacan olivierlacan commented Mar 24, 2015

@waynerobinson Considering this comment the idea is to route commands to rake anyway so this command would have to be added to the supported hybrid rails/rake commands.

@waynerobinson
Copy link

@waynerobinson waynerobinson commented Mar 24, 2015

@olivierlacan no problem, just making sure there is some consistency here (not that I whole-heartedly approve of everything rails).

@emilsoman
Copy link
Contributor

@emilsoman emilsoman commented Mar 26, 2015

@hjoo the PR title is misguiding - it looks like the rake task was added in a different PR ?

@eileencodes
Copy link
Member

@eileencodes eileencodes commented Mar 26, 2015

@emilsoman it was but the commit has the correct title. I've edited it but I don't think it's a big deal.

@eileencodes eileencodes changed the title Created rake restart task. Rake restart task no longer loads entire Rails environment when run Mar 26, 2015
@seanarnold
Copy link

@seanarnold seanarnold commented Mar 26, 2015

I agree with @waynerobinson . if we're adding this then add rails restart too. Especially since you start the server with rails server, it makes sense (to me at least) to have a rails restart command.

@rafaelfranca
Copy link
Member

@rafaelfranca rafaelfranca commented Mar 26, 2015

@seanarnold it will be added.

@seanarnold
Copy link

@seanarnold seanarnold commented Mar 26, 2015

👍

@rails rails locked and limited conversation to collaborators Mar 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

9 participants