Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `rake initializer` #19323

Merged
merged 1 commit into from Mar 13, 2015
Merged

Add `rake initializer` #19323

merged 1 commit into from Mar 13, 2015

Conversation

@naoty
Copy link
Contributor

@naoty naoty commented Mar 13, 2015

This task prints out initializers for an application. It is useful to
develop a rubygem which involves the initialization process.

This task prints out initializers for an application. It is useful to
develop a rubygem which involves the initialization process.
rafaelfranca added a commit that referenced this pull request Mar 13, 2015
Add `rake initializer`
@rafaelfranca rafaelfranca merged commit 814d4da into rails:master Mar 13, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@chancancode
Copy link
Member

@chancancode chancancode commented Mar 20, 2015

Should this be rake initializers? ( <--> rake routes)

@rafaelfranca
Copy link
Member

@rafaelfranca rafaelfranca commented Mar 20, 2015

We have rake middleware 😢

@chancancode
Copy link
Member

@chancancode chancancode commented Mar 20, 2015

Hmm true. But in that case it's going to disagree with either one of them anyway, so might as well go with whatever we think is "better" 😛

There's also rake annotations, so my vote is for plural!

@rafaelfranca
Copy link
Member

@rafaelfranca rafaelfranca commented Mar 20, 2015

👍

@chancancode
Copy link
Member

@chancancode chancancode commented Mar 20, 2015

Committed 9e80c29 😃

chancancode added a commit that referenced this pull request Mar 20, 2015
Also edited the copy to be more consistent with `rake routes`.

See #19323.
@andrewhr
Copy link

@andrewhr andrewhr commented Mar 21, 2015

rake middleware could be read like "Give me our middleware stack". I like to imagine that's why it's in the singular 🚲 🎨

@naoty
Copy link
Contributor Author

@naoty naoty commented Mar 21, 2015

I'm also agree with rake initializers. 👌

@naoty naoty deleted the naoty:rake_initializer branch Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.