Add config.active_record.dump_schemas.

[rywall]

Fixes db:structure:dump when using schema_search_path and PostgreSQL extensions.

Closes #17157.

[rywall]

@senny @jimmykarily Here is a first pass. Feedback appreciated. :)

[senny]

The docs should mention the default value.

[rywall]

I was trying to model it after the documentation for schema_format (above) which doesn't specify the default in the doc. Should I change both?

[senny]

Let's focus on this change for now. If you have time, you can update the other in a separate PR.

[rywall]

Done.

[senny]

@rywall looking good. Do you think you could add test-cases for this new functionality?

[jimmykarily]

👍

[rywall]

@senny I've added some tests. Anything else?

[senny]

let's use an example with two schemas as well.

[rywall]

Done.

[senny]

@rywall I added a couple comments. Thank you for your work on this 💛

[rywall]

I've refactored the tests to avoid side effects. I think I've addressed all you other comments as well. Thanks for your feedback. The pull request is much better for it. 👍

[senny]

@rywall awesome! Thank you for your work 💛

[jimmykarily]

Thanks!

[GUI]

Thanks, @rywall! If anyone else stumbles upon this and would find this functionality useful in Rails 3 or Rails 4, I created a gem to backport this functionality to those versions of Rails: https://github.com/GUI/activerecord-postgres-dump-schemas

[njakobsen]

❤️ @GUI.

[NikolayS]

Thanks for this.

Any plans to support pg_dump's --exclude-schema as well?

In some cases, it might be more convenient to have a "black list", not a "white" one.

[rainhead]

For anyone looking for a way to dump extensions along with a subset of schemas, or otherwise needing extra control over pg_dump, set ActiveRecord::Tasks::DatabaseTasks.structure_dump_flags:

ActiveRecord::Tasks::DatabaseTasks.structure_dump_flags = %w{
  --exclude-schema=schema2
  --exclude-schema=schema3
}