Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass wrapped class name to Sidekiq for logging purposes #19482

Merged
merged 1 commit into from Mar 23, 2015

Conversation

@mperham
Copy link
Contributor

commented Mar 23, 2015

Sidekiq logs the name of the job class being performed. Because
ActiveJob wraps the class, this means currently every job logs as an AJ::JobWrapper
instead of the actual job name.

Will help fix mperham/sidekiq#2248

Pass wrapped class name to Sidekiq for logging purposes
Sidekiq logs the name of the job class being performed.  Because
ActiveJob wraps the class, this means every job logs as an AJ::JobWrapper
instead of the actual class name.

Will help fix mperham/sidekiq#2248
rafaelfranca added a commit that referenced this pull request Mar 23, 2015
Merge pull request #19482 from mperham/master
Pass wrapped class name to Sidekiq for logging purposes

@rafaelfranca rafaelfranca merged commit 503d9e1 into rails:master Mar 23, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mperham

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2015

Any chance this can get in 4.2? It's an active issue for all AJ users.

rafaelfranca added a commit that referenced this pull request Mar 23, 2015
Merge pull request #19482 from mperham/master
Pass wrapped class name to Sidekiq for logging purposes
@rafaelfranca

This comment has been minimized.

Copy link
Member

commented Mar 23, 2015

Backported at 94249d4

@rafaelfranca

This comment has been minimized.

Copy link
Member

commented Mar 23, 2015

@mperham just did it.

@estum

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2015

But it still logs the long AJWrapper name, doesn't it? I use a hook to replace it with the real job class name: https://gist.github.com/estum/dd67fc80bee60966672c.

@mperham

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2015

Not on Sidekiq master. ;-)

On Mar 27, 2015, at 17:33, Tõnis Simo notifications@github.com wrote:

But it still logs the long AJWrapper name, doesn't it? I use a hook to replace it with the real job class name: https://gist.github.com/estum/dd67fc80bee60966672c.


Reply to this email directly or view it on GitHub.

@estum

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2015

@mperham, yay, fresh commits! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.