Fixes #6073, #6383 - Postgres added tsvector type, and fixed money_precision= NoMethodError #197

Closed
wants to merge 2 commits into from

9 participants

@brockgr

This fixes a couple of issues that I have encountered while using postgres tesearch functionality:

#6073 - Patch by Robert Sosinski (www.robertsosinski.com) adding the tsvector data type

#6382 - Patch to fix money_precision= setting the variable in the wrong class

@tenderlove
Ruby on Rails member

Any chance we could get a test for this?

@scottlowe

I've written some simple tests to support the PostgreSQL tsvector data type patch for #6073.

Writing these tests has raised some questions. Whilst we can now schema dump without fear, is the data type useful on it's own? I can't think of a case where I would use the tsvector type without a trigger and of course that is not something that is presently supported in the schema DSL (or perhaps I've missed something?).

Tests are here, on the tsvector_tests_6073 branch:
https://github.com/scottlowe/rails/commits/tsvector_tests_6073

EDIT:

I have read the Rails submission guidelines and have now created a patch and attached it to Lighthouse ticket #6073:

https://rails.lighthouseapp.com/projects/8994/tickets/6073

@sikachu
Ruby on Rails member

@tenderlove can I get your feedback on his test here? scottlowe@395902b

If you said yes, I think we can merge this pull request and then cherry-pick that commit.

@tenderlove tenderlove was assigned Jun 1, 2011
@scottlowe

I would be more than happy to write additional tests or amend what is there, if there is an appetite for it.

@tenderlove
Ruby on Rails member

@scottlowe no, this is good. I'll merge it in.

@JeanMertz

Was this ever merged in? @tenderlove

@beanieboi

the tsvector support got merged with this pull request #310

@xaviershay

Recommend this ticket be closed, no further action is appears to be required.

@tenderlove tenderlove closed this Jul 23, 2011
@eriko

Could someone pull this in to 3-0-stable as it is getting tiresome hand patching it in every time I deploy a 3.0 based app.

@kwi

Agreed, please, merge in rails 3 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment