Use #prepend rather than using 2 aliases #19752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki24
added a commit
to yuki24/rails
that referenced
this pull request
Apr 14, 2015
This is required to run rails#19752 successfully.
yuki24
force-pushed
the
use-prepend-rather-than-alias
branch
2 times, most recently
from
783acaf
to
93078ca
Compare
|
For some reason the build status didn't show up here, but it's green ✅ on travis. |
|
Nice catch! Looks good for me. |
| else | ||
| include_without_range?(value) | ||
| module ActiveSupport | ||
| module IncludeWithRange |
There was a problem hiding this comment.
I think we should nodoc this constant as well, it will be weird to have it showing up in the docs.
yuki24
force-pushed
the
use-prepend-rather-than-alias
branch
from
93078ca
to
aa255a3
Compare
| if value.is_a?(::Range) | ||
| # 1...10 includes 1..9 but it does not include 1..10. | ||
| operator = exclude_end? && !value.exclude_end? ? :< : :<= | ||
| super(value.first) && value.last.send(operator, last) |
There was a problem hiding this comment.
Sorry, I just noticed it now, but this indent seems weird doesn't it?
There was a problem hiding this comment.
I'm not sure, I'm happy to remove the line break here, though. WDYT?
There was a problem hiding this comment.
The second line has extra indent, I think it should be indented like this:
operator = exclude_end? && !value.exclude_end? ? :< : :<=
super(value.first) && value.last.send(operator, last)There was a problem hiding this comment.
Thanks, I missed that. the commit has been updated.
Merged
yuki24
force-pushed
the
use-prepend-rather-than-alias
branch
from
aa255a3
to
d3684c4
Compare
carlosantoniodasilva
added a commit
that referenced
this pull request
Apr 14, 2015
Use #prepend rather than using 2 aliases
|
thanks! 💚💛❤️💙💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up pull request to #19434. Now that Ruby 2.2.2 is out and we can use
#prependanywhere.cc/ @rafaelfranca @kirs