Remove :rescue_format option for translate helper #20019

Merged
merged 1 commit into from May 5, 2015

Conversation

Projects
None yet
2 participants
@imanel
Contributor

imanel commented May 4, 2015

:rescue_format is not documented, it's not working in I18n and support for it was removed with Rails 4.1.0.

This pull request removes leftovers from that time - two tests that were always passing, one old test name and flag that was working in nearly exact the same way as passing :raise flag.

Rails 5.0 is great moment to remove this flag - next time will be probably in two years with 6.x branch since it might be considered as backward-incompatible.

@imanel

This comment has been minimized.

Show comment
Hide comment
@imanel

imanel May 4, 2015

Contributor

/cc @matthewd

Contributor

imanel commented May 4, 2015

/cc @matthewd

@imanel

This comment has been minimized.

Show comment
Hide comment
@imanel

imanel May 4, 2015

Contributor

As for deprecation notice - it shows for anyone using this flag since I18n v0.5.1 that was included in Rails 3.0.6.

Contributor

imanel commented May 4, 2015

As for deprecation notice - it shows for anyone using this flag since I18n v0.5.1 that was included in Rails 3.0.6.

matthewd added a commit that referenced this pull request May 5, 2015

Merge pull request #20019 from imanel/remove_rescue_format
Remove :rescue_format option for translate helper

@matthewd matthewd merged commit 4fa9351 into rails:master May 5, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@imanel imanel deleted the imanel:remove_rescue_format branch May 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment