Remove :rescue_format option for translate helper #20019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r supported by I18n.
|
/cc @matthewd |
|
As for deprecation notice - it shows for anyone using this flag since I18n v0.5.1 that was included in Rails 3.0.6. |
matthewd
added a commit
that referenced
this pull request
May 5, 2015
Remove :rescue_format option for translate helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:rescue_formatis not documented, it's not working in I18n and support for it was removed with Rails 4.1.0.This pull request removes leftovers from that time - two tests that were always passing, one old test name and flag that was working in nearly exact the same way as passing
:raiseflag.Rails 5.0 is great moment to remove this flag - next time will be probably in two years with 6.x branch since it might be considered as backward-incompatible.