New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide provider_job_id to qu adapter. #20064

Merged
merged 1 commit into from May 8, 2015

Conversation

Projects
None yet
4 participants
@kddeisz
Contributor

kddeisz commented May 7, 2015

Further work to provide provider_job_id for queue adapters.

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca May 7, 2015

Member

Don't forget the CHANGELOG

Member

rafaelfranca commented May 7, 2015

Don't forget the CHANGELOG

@kddeisz

This comment has been minimized.

Show comment
Hide comment
@kddeisz

kddeisz May 7, 2015

Contributor

@rafaelfranca - thanks! Just updated it.

Contributor

kddeisz commented May 7, 2015

@rafaelfranca - thanks! Just updated it.

Provide provider_job_id to qu adapter.
Further work to provide provider_job_id for queue adapters.
@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca May 7, 2015

Member

Tests seems to be broken.

Member

rafaelfranca commented May 7, 2015

Tests seems to be broken.

@kddeisz

This comment has been minimized.

Show comment
Hide comment
@kddeisz

kddeisz May 7, 2015

Contributor

It's not displaying the travis errors for me, do you have a link? It was broken until about 20 minutes ago - is it still now? I had to add the "unless qu_job.nil?" because of the different backends.

Contributor

kddeisz commented May 7, 2015

It's not displaying the travis errors for me, do you have a link? It was broken until about 20 minutes ago - is it still now? I had to add the "unless qu_job.nil?" because of the different backends.

@kddeisz

This comment has been minimized.

Show comment
Hide comment
@kddeisz

kddeisz May 8, 2015

Contributor

@rafaelfranca any idea how to proceed? Both the regular and integration tests are passing for me, so I don't exactly know what to do. Thanks.

Contributor

kddeisz commented May 8, 2015

@rafaelfranca any idea how to proceed? Both the regular and integration tests are passing for me, so I don't exactly know what to do. Thanks.

@matthewd matthewd closed this May 8, 2015

@matthewd matthewd reopened this May 8, 2015

@kddeisz

This comment has been minimized.

Show comment
Hide comment
@kddeisz

kddeisz May 8, 2015

Contributor

Thanks @matthewd - looks like it's good now.

Contributor

kddeisz commented May 8, 2015

Thanks @matthewd - looks like it's good now.

test 'should supply a provider_job_id when available for delayed jobs' do
skip unless adapter_is?(:delayed_job, :sidekiq, :que)

This comment has been minimized.

@jvanbaarsen

jvanbaarsen May 8, 2015

Contributor

I think you forgot to add the provider_job_id for qu in the enqueed_at method.

@jvanbaarsen

jvanbaarsen May 8, 2015

Contributor

I think you forgot to add the provider_job_id for qu in the enqueed_at method.

This comment has been minimized.

@kddeisz

kddeisz May 8, 2015

Contributor

Yeah qu doesn't support scheduled jobs, so I didn't include that in the test.

@kddeisz

kddeisz May 8, 2015

Contributor

Yeah qu doesn't support scheduled jobs, so I didn't include that in the test.

This comment has been minimized.

@jvanbaarsen

jvanbaarsen May 8, 2015

Contributor

Ah sorry, I only saw the first line of def enqueue_at(job, timestamp, *args) #:nodoc: did not read the full method body.

@jvanbaarsen

jvanbaarsen May 8, 2015

Contributor

Ah sorry, I only saw the first line of def enqueue_at(job, timestamp, *args) #:nodoc: did not read the full method body.

rafaelfranca added a commit that referenced this pull request May 8, 2015

Merge pull request #20064 from kddeisz/qu_provider_job_id
Provide provider_job_id to qu adapter.

@rafaelfranca rafaelfranca merged commit fca8a7a into rails:master May 8, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kddeisz kddeisz deleted the kddeisz:qu_provider_job_id branch May 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment