Skip to content

Deprecate assert_template and assigns().#20138

Merged
rafaelfranca merged 1 commit into
rails:masterfrom
tgxworld:deprecated_assert_template
Jun 1, 2015
Merged

Deprecate assert_template and assigns().#20138
rafaelfranca merged 1 commit into
rails:masterfrom
tgxworld:deprecated_assert_template

Conversation

@tgxworld
Copy link
Copy Markdown
Contributor

@tgxworld tgxworld commented May 13, 2015

Related: #18950.

cc/ @dhh

tgxworld
tgxworld reviewed May 13, 2015
View reviewed changes
Comment thread actionpack/test/controller/action_pack_assertions_test.rb
Copy link
Copy Markdown
Contributor Author

@tgxworld tgxworld May 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated in https://github.com/tgxworld/rails/blob/deprecated_assert_template/actionpack/test/controller/action_pack_assertions_test.rb#L492-L495 and https://github.com/tgxworld/rails/blob/deprecated_assert_template/actionpack/test/controller/action_pack_assertions_test.rb#L518-L522

@tgxworld tgxworld force-pushed the deprecated_assert_template branch 6 times, most recently from 7bcd3f9 to db2d0fe Compare May 23, 2015 06:39
@tgxworld tgxworld changed the title Deprecate assert_template. Deprecate assert_template and assigns(). May 23, 2015
@tgxworld
Copy link
Copy Markdown
Contributor Author

tgxworld commented May 23, 2015

@dhh @matthewd I've deprecated both assigns() and assert_template and extraced both methods into a plugin. I'll still have to publish the gem though.

@tgxworld
Copy link
Copy Markdown
Contributor Author

tgxworld commented May 23, 2015

Done! Gem published at https://rubygems.org/gems/rails-controller-testing.

@tgxworld tgxworld force-pushed the deprecated_assert_template branch 2 times, most recently from 47e55c9 to 8c6c96e Compare May 27, 2015 09:24
rafaelfranca
rafaelfranca reviewed May 28, 2015
View reviewed changes
Comment thread actionpack/lib/action_controller/template_assertions.rb Outdated
Copy link
Copy Markdown
Member

@rafaelfranca rafaelfranca May 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should raise a NoMethodError and point to the gem so we can remove all the implementation

Copy link
Copy Markdown
Contributor Author

@tgxworld tgxworld May 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we had to deprecate it first?

Copy link
Copy Markdown
Member

@rafaelfranca rafaelfranca May 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are extracting a gem there is no need. The NoMethodError message should tell about the gem and people can get it work adding the gem to their Gemfile.

Copy link
Copy Markdown
Contributor Author

@tgxworld tgxworld May 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to transfer the Gem to Rails? Although Rails isn't supporting these two methods, it seems weird that we're pointing to my personal repository.

Copy link
Copy Markdown
Member

@rafaelfranca rafaelfranca May 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 transfer to Rails so I can give you commit access.

Copy link
Copy Markdown
Contributor Author

@tgxworld tgxworld May 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I can't transfer without admin rights. Better to fork in this case?

Copy link
Copy Markdown
Member

@rafaelfranca rafaelfranca May 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transfer to me so I can transfer to Rails.

Copy link
Copy Markdown
Contributor Author

@tgxworld tgxworld May 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll remove the method soon.

Copy link
Copy Markdown
Member

@rafaelfranca rafaelfranca May 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove the methods, just change their implementation to:

def assert_template(*)
  raise NoMethodError, "assert_template was extracted to a gem. To continue using it use the ..."
end

Copy link
Copy Markdown
Contributor Author

@tgxworld tgxworld May 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'll remove the internal tests in this case.

@tgxworld tgxworld force-pushed the deprecated_assert_template branch 3 times, most recently from 86b91d7 to eda79db Compare May 30, 2015 02:59
@tgxworld
Copy link
Copy Markdown
Contributor Author

tgxworld commented May 30, 2015

Updated but there is some problem on Travis that isn't related.

@rafaelfranca rafaelfranca added this to the 5.0.0 milestone May 30, 2015
@rafaelfranca
Copy link
Copy Markdown
Member

rafaelfranca commented May 30, 2015

Great work! Could you add a CHANGELOG entry?

@tgxworld tgxworld force-pushed the deprecated_assert_template branch from eda79db to 28d34e2 Compare May 30, 2015 03:26
@tgxworld
Copy link
Copy Markdown
Contributor Author

tgxworld commented May 30, 2015

Great work! Could you add a CHANGELOG entry?

O yeah forgot about it XD. Done 😄

rafaelfranca
rafaelfranca reviewed May 30, 2015
View reviewed changes
Comment thread actionpack/CHANGELOG.md Outdated
Copy link
Copy Markdown
Member

@rafaelfranca rafaelfranca May 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to tell that these methods were extracted to the gem and point to it on the changelog.

@tgxworld tgxworld force-pushed the deprecated_assert_template branch from 28d34e2 to ca83436 Compare May 30, 2015 06:14
tgxworld
tgxworld reviewed May 30, 2015
View reviewed changes
Comment thread actionpack/CHANGELOG.md
Copy link
Copy Markdown
Contributor Author

@tgxworld tgxworld May 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafaelfranca Is this ok? 😄

rafaelfranca added a commit that referenced this pull request Jun 1, 2015
@rafaelfranca
Merge pull request #20138 from tgxworld/deprecated_assert_template
bdfc662 
Deprecate `assert_template` and `assigns()`.
@rafaelfranca rafaelfranca merged commit bdfc662 into rails:master Jun 1, 2015
@tgxworld tgxworld mentioned this pull request Jun 2, 2015
Closed
@kirs
Copy link
Copy Markdown
Member

kirs commented Jun 6, 2015

👍 great job!

@rafaelfranca rafaelfranca modified the milestones: 5.0.0 [temp], 5.0.0 Dec 30, 2015
@tgxworld tgxworld deleted the deprecated_assert_template branch August 30, 2019 06:43
@pirj pirj mentioned this pull request Aug 20, 2020
Open
@edwardloveall edwardloveall mentioned this pull request Mar 26, 2022
Merged
edwardloveall added a commit to edwardloveall/portfolio that referenced this pull request Mar 27, 2022
@edwardloveall
Ensure internal posts use the blog layout
a79cb69 
I first thought this was markdown so I updated the feature post spec (it's now improved but unrelated to the fix). Then I discovered that it's because InternalPostsController was using the default application layout instead of the blog layout. Easy fix, but what about the test?

I first tried to use a controller test. However, asserting that a specific layout is used is deprecated: rails/rails#20138 Then I tried a feature spec. This works, but I'm still just testing things unrelated to what I care about. In particular, the main navigation (About Projects Music) exists in the application layout, but not in the blog layout. That works for now, but it still didn't feel like the right way to test if a post has the correct styles applied to it.

I landed on actually asserting on the styles using Capybara's [matches_style] matcher. This requires that I use a non-headless browser to render the CSS styles of a page.

[matches_style]: https://rubydoc.info/github/teamcapybara/capybara/master/Capybara%2FNode%2FMatchers:matches_style%3F
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

actionpack

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@tgxworld @rafaelfranca @kirs @dhh @simi