Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Add bang version to OrderedOptions #20208
Thank you for the pull request.
Not true. There is no rule about this in any place and even if it is a rule, there is cases where it doesn't make sense.
I'm having problem to understand where this would be useful, could you give us an example?
@rafaelfranca Absolutely right, there is no such rule.
Case in point
if (slack_url = Rails.application.secrets.slack_url).present? $slack_notifier = Slack::Notifier.new(slack_url) else Rails.logger.error("Unable to find slack_url in secrets.yml") raise "Unable to find slack_url in secrets.yml" end
gets replaced by
$slack_notifier = Slack::Notifier.new(Rails.application.secrets.slack_url!)
This is a similar style to
What do you think?