Add bang version to OrderedOptions

[gaurish]

Every method should have a bang counter-part. if someone uses a bang version & its not defined. it will raise an ArgumentError.

example(normal version)
Rails.application.secrets.big_query

bang version
Rails.application.secrets.big_query!

By:
Aditya Sanghi(@asanghi)
Gaurish Sharma(@gaurish)

[raysrashmi]

@gaurish Extra can be removed

[rafaelfranca]

Thank you for the pull request.

Every method should have a bang counter-part.

Not true. There is no rule about this in any place and even if it is a rule, there is cases where it doesn't make sense.

I'm having problem to understand where this would be useful, could you give us an example?

[asanghi]

@rafaelfranca Absolutely right, there is no such rule.

secrets.yml is more likely than not to contain passwords/keys to services which might be essential to your application's execution. Without those keys the application is unlikely to work as expected (or crash in unexpected ways). The bang version of the method basically allows us to crash in a more expected way, letting us know that a blank has been encountered when it's not expected. In absence of this, we're more likely to write custom code checking for blanks and handling it with custom error methods (and then possibly erroring out anyway).

Case in point

if (slack_url = Rails.application.secrets.slack_url).present?
  $slack_notifier = Slack::Notifier.new(slack_url)
else
  Rails.logger.error("Unable to find slack_url in secrets.yml")
  raise "Unable to find slack_url in secrets.yml"
end

gets replaced by

  $slack_notifier = Slack::Notifier.new(Rails.application.secrets.slack_url!)

This is a similar style to .save!, and .create! methods where ! indicates that an exception might be raised by this method call.

What do you think?

[rafaelfranca]

@asanghi thanks for the explanation.

@gaurish Could you add a CHANGELOG entry?

[rafaelfranca]

Can we use if/else? The line is too long.

[gaurish]

PR Updated according to feedback given.

[asanghi]

/cc @rafaelfranca seems okay now?

[chopmo]

Small nitpick: The last closing parens should be deleted.