Deprecate the keys for association restrict_dependent_destroy errors in favor of new key names
#20668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repinel
force-pushed
the
rename-restrict-dependent-destroy-i18n-key
branch
3 times, most recently
from
9911b08 to
f13500c
Compare
|
@rafaelfranca What do you think? |
repinel
force-pushed
the
rename-restrict-dependent-destroy-i18n-key
branch
from
f13500c to
fd3a8c2
Compare
|
@rafaelfranca Is this one still valid? (sorry for the multiples pings) |
No problem at all. I way back in my backlog lately. |
| assert !firm.errors.empty? | ||
|
|
||
| assert_equal 'message for deprecated key', firm.errors[:base].first | ||
| assert RestrictedWithErrorFirm.exists?(:name => 'restrict') |
Previously `has_one` and `has_many` associations were using the `one` and `many` keys respectively. Both of these keys have special meaning in I18n (they are considered to be pluralizations) so by renaming them to `has_one` and `has_many` we make the messages more explicit and most importantly they don't clash with linguistical systems that need to validate translation keys (and their pluralizations). The `:'restrict_dependent_destroy.one'` key should be replaced with `:'restrict_dependent_destroy.has_one'`, and `:'restrict_dependent_destroy.many'` with `:'restrict_dependent_destroy.has_many'`. [Roque Pinel & Christopher Dell]
repinel
force-pushed
the
rename-restrict-dependent-destroy-i18n-key
branch
from
fd3a8c2 to
b184398
Compare
|
@rafaelfranca I fixed the hash syntax. |
rafaelfranca
added a commit
that referenced
this pull request
Jul 21, 2015
…roy-i18n-key Deprecate the keys for association `restrict_dependent_destroy` errors in favor of new key names
|
💚 💛 💙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by #11658 (comment), it deprecates the
restrict_dependent_destroyerrors keys in favor of better key names.The
:'restrict_dependent_destroy.one'key should be replaced with:'restrict_dependent_destroy.has_one', and:'restrict_dependent_destroy.many'with:'restrict_dependent_destroy.has_many'.@rafaelfranca Is this what you expected?
Closes #11658