[ci skip] docs: making clear that perform_caching has a limited impact #20736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,7 +8,7 @@ module ActionController | |||
| # | |||
| # You can read more about each approach by clicking the modules below. | |||
| # | |||
| # Note: To turn off all caching, set | |||
| # Note: To turn off all caching provided by ActionController, set | |||
|
Thank you for the pull request. Just change ActionController to Action Controller since we are talking about the component, not the module. |
|
Did the changes and squashed under the same commit message. Should be good now. |
| @@ -31,6 +31,8 @@ the relevant `config/environments/*.rb` file: | |||
| config.action_controller.perform_caching = true | |||
| ``` | |||
|
|
|||
| NOTE: Changing the value of `config.action_controller.perform_caching` will only have an effect on the caching provided by the Action Controller component. For instance, it will not impact low-level caching, that we address [below](#low-level-caching). | |||
There was a problem hiding this comment.
Could you wrap this line around 80 chars please ?
There was a problem hiding this comment.
This is still not addressed but then this should be good to be merged.
There was a problem hiding this comment.
Didn't see that. Since many other places in the same doc are not wrapped (see the info) I didn't see the need for it at first. It's done now.
robin850
added a commit
that referenced
this pull request
Jul 13, 2015
[ci skip] docs: making clear that perform_caching has a limited impact
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #20733