Check if default is a hash rather than checking if it responds to merge#20840
Closed
sgringwe wants to merge 1 commit into
Closed
Check if default is a hash rather than checking if it responds to merge#20840sgringwe wants to merge 1 commit into
sgringwe wants to merge 1 commit into
Conversation
…ge. This fixes scenarios where objects (such as nil) have the 'merge' method defined for other reasons.
Contributor
|
@sgringwe See my comment on CanCanCommunity/cancancan#229. I believe duck typing instead of explicitly checking the class is the preferred approach for these scenarios with ruby. |
Member
Agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes scenarios where objects (such as nil) have the 'merge' method defined for other reasons. In this situation, the CanCan gem had defined merge: CanCanCommunity/cancancan#229. It is debatable whether cancan or rails is 'at fault' here, but checking if default is a hash feels more correct based on my understanding of the intended behavior.
If you'd like for a test to be added just let me know.
This fixes #20837