New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bin/update script to update application automatically #20972

Merged
merged 1 commit into from Aug 7, 2015

Conversation

Projects
None yet
5 participants
@meinac
Contributor

meinac commented Jul 21, 2015

I think this a helpful script for team members after pulling the changes from remote repository. They can add whatever they want to update their application in this script.

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
Member

rafaelfranca commented Jul 27, 2015

@rafaelfranca rafaelfranca added this to the 5.0.0 milestone Jul 27, 2015

@dhh

This comment has been minimized.

Show comment
Hide comment
@dhh

dhh Jul 27, 2015

Member

👍

Member

dhh commented Jul 27, 2015

👍

@carlosantoniodasilva

This comment has been minimized.

Show comment
Hide comment
@carlosantoniodasilva

carlosantoniodasilva Jul 28, 2015

Member

Sounds good to me.

Member

carlosantoniodasilva commented Jul 28, 2015

Sounds good to me.

Show outdated Hide outdated railties/CHANGELOG.md Outdated
@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Aug 6, 2015

Member

I've declared this method here and I don't like what I did. I think this is a bad example to show developers to repeat yourself. Maybe we can define this method in active_support to use in other places, I didn't think declaring this method inside of a file in bin folder because someone can remove it. Any advice?

It is a script so there is no problem of repeating it. Over DRy is also a problem

Member

rafaelfranca commented Aug 6, 2015

I've declared this method here and I don't like what I did. I think this is a bad example to show developers to repeat yourself. Maybe we can define this method in active_support to use in other places, I didn't think declaring this method inside of a file in bin folder because someone can remove it. Any advice?

It is a script so there is no problem of repeating it. Over DRy is also a problem

@rafaelfranca

View changes

Show outdated Hide outdated railties/lib/rails/generators/rails/app/templates/bin/update Outdated
@rafaelfranca

View changes

Show outdated Hide outdated railties/lib/rails/generators/rails/app/templates/bin/update Outdated
@meinac

This comment has been minimized.

Show comment
Hide comment
@meinac

meinac Aug 6, 2015

Contributor

@rafaelfranca I fixed the problems you've pointed, WDYT about this now?

Contributor

meinac commented Aug 6, 2015

@rafaelfranca I fixed the problems you've pointed, WDYT about this now?

Added bin/update script to update application automatically
use system!

fix changelog

use bundle check first and use rake

use system instead system! for bundle check
@meinac

This comment has been minimized.

Show comment
Hide comment
@meinac

meinac Aug 7, 2015

Contributor

@matthewd Thanks for the point, I've fixed it.

Contributor

meinac commented Aug 7, 2015

@matthewd Thanks for the point, I've fixed it.

rafaelfranca added a commit that referenced this pull request Aug 7, 2015

Merge pull request #20972 from vngrs/bin_update
Added bin/update script to update application automatically

@rafaelfranca rafaelfranca merged commit dcc4783 into rails:master Aug 7, 2015

@rafaelfranca rafaelfranca modified the milestones: 5.0.0 [temp], 5.0.0 Dec 30, 2015

@bradleybeddoes bradleybeddoes referenced this pull request Jun 21, 2016

Open

Rails 5 and Strap #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment