-
Notifications
You must be signed in to change notification settings - Fork 22.2k
Added bin/update script to update application automatically #20972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I like the idea, it follows https://github.com/github/scripts-to-rule-them-all. @dhh @carlosantoniodasilva @fxn @chancancode WDYT? |
|
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be interesting to take in consideration the system! implementation added by other PR, to abort in case of a failure.
|
Sounds good to me. |
railties/CHANGELOG.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to be a bit more descriptive here. What does "update application automatically" really mean? Is that different from deploy? Just to make intents clear.
It is a script so there is no problem of repeating it. Over DRy is also a problem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to call bundle check first.
|
@rafaelfranca I fixed the problems you've pointed, WDYT about this now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per #20992, system! never returns false
use system! fix changelog use bundle check first and use rake use system instead system! for bundle check
|
@matthewd Thanks for the point, I've fixed it. |
Added bin/update script to update application automatically
I think this a helpful script for team members after pulling the changes from remote repository. They can add whatever they want to update their application in this script.