Use memoization for collection associations ids reader #21092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -62,8 +62,10 @@ def ids_reader | |||
| record.send(reflection.association_primary_key) | |||
| end | |||
| else | |||
| column = "#{reflection.quoted_table_name}.#{reflection.association_primary_key}" | |||
| scope.pluck(column) | |||
| @association_ids ||= ( | |||
There was a problem hiding this comment.
@egilburg I don't think extra space before = is valid ruby syntax.
There was a problem hiding this comment.
Oh, I think you are taking about next line. I'm going to fix it.
Fixes #21082 remove extra space
rafaelfranca
added a commit
that referenced
this pull request
Aug 6, 2015
Use memoization for collection associations ids reader
microweb10
added a commit
to AyuntamientoMadrid/consul
that referenced
this pull request
Apr 17, 2019
Failure:
Budget::Stats#total_votes returns the number of total votes
Failure/Error: create(:budget_ballot_line, investment:
create(:budget_investment, :selected, budget: budget))
ActiveRecord::RecordInvalid:
Validation failed: Money insufficient funds
spec/models/budget/stats_spec.rb:109
Associations ids changed since this PR
rails/rails#21092
By forcing the object to be reloaded, the result is as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can see from the source of the Rails we don't need to set
@association_idsto nil to force ActiveRecord to execute a query because if user changes the association either by calling records_writer or ids_writer the relation will be marked as loaded and rails will return ids from loaded collection.Fixes #21082