Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XML Serialization from core #21161

Merged
merged 1 commit into from Aug 7, 2015
Merged

Remove XML Serialization from core #21161

merged 1 commit into from Aug 7, 2015

Conversation

@zzak
Copy link
Member

zzak commented Aug 7, 2015

This includes the following classes and method:

  • ActiveModel::Serializers::Xml
  • ActiveRecord::Serialization::XmlSerializer
  • ActiveRecord::Serialization#to_xml

This code has moved to an external gem called activemodel-serializers-xml. (which we can move to the Rails org.)
#20612

This includes the following classes:

- ActiveModel::Serializers::Xml
- ActiveRecord::Serialization::XmlSerializer
rafaelfranca added a commit that referenced this pull request Aug 7, 2015
Remove XML Serialization from core
@rafaelfranca rafaelfranca merged commit 9645820 into master Aug 7, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@rafaelfranca rafaelfranca deleted the rm-xml-serializer branch Aug 7, 2015
@rafaelfranca
Copy link
Member

rafaelfranca commented Aug 7, 2015

Re #20612

tpoulsen added a commit to smartlogic/toystore that referenced this pull request Oct 10, 2016
Bumps versions for `activesupport` and `activemodel` to allow v5 for
each.

Adds `activemodel-serializers-xml`, as this was removed in Rails 5 (ref:
rails/rails#21161).
cdccollins added a commit to alphagov/asset-manager that referenced this pull request Jul 7, 2020
Updated mongoid and state_machines-mongoid so that rails could move to version 6.

Was getting `uninitialized constant ActiveModel::Serializers::Xml` so added
activemodel-serializers-xml gem (was removed from core rails rails/rails#21161)
cdccollins added a commit to alphagov/asset-manager that referenced this pull request Jul 8, 2020
Updated mongoid and state_machines-mongoid so that rails could move to version 6.

Was getting `uninitialized constant ActiveModel::Serializers::Xml` so added
activemodel-serializers-xml gem (was removed from core rails rails/rails#21161)
cdccollins added a commit to alphagov/asset-manager that referenced this pull request Jul 8, 2020
Updated mongoid and state_machines-mongoid so that rails could move to version 6.

Was getting `uninitialized constant ActiveModel::Serializers::Xml` so added
activemodel-serializers-xml gem (was removed from core rails rails/rails#21161)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.