Support mysql2 0.4.0, first release with prepared statements support #21536

Merged
merged 1 commit into from Sep 8, 2015

Projects

None yet

5 participants

@jeremy
Member
jeremy commented Sep 7, 2015

Broadens AR gem requirement from ~> 0.3.18 to >= 0.3.18, < 0.5

Known failure on Ruby 2.3/trunk: brianmario/mysql2#671

@rails-bot

r? @carlosantoniodasilva

(@rails-bot has picked a reviewer for you, use r? to override)

@jeremy
Member
jeremy commented Sep 8, 2015

Unrelated build failure with SassImporter: https://travis-ci.org/rails/rails/jobs/79201176#L841-L842

@rafaelfranca
Member

Yeah. Already working in a fix.

@rafaelfranca
Member

Fixed

@rafaelfranca
Member

:shipit:

@jeremy jeremy merged commit 81dd387 into rails:master Sep 8, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jeremy jeremy deleted the jeremy:support-mysql2-0.4.0 branch Sep 8, 2015
@sodabrew sodabrew commented on the diff Sep 8, 2015
@@ -90,7 +90,7 @@ platforms :ruby do
group :db do
gem 'pg', '>= 0.18.0'
gem 'mysql', '>= 2.9.0'
- gem 'mysql2', '>= 0.3.18'
+ gem 'mysql2', '>= 0.4.0', github: 'brianmario/mysql2'
@sodabrew
sodabrew Sep 8, 2015 Contributor

Is the github reference required so that ruby-head tests pass?

@sodabrew sodabrew commented on the diff Sep 8, 2015
Gemfile.lock
@@ -20,6 +20,12 @@ GIT
redis-namespace
GIT
+ remote: git://github.com/brianmario/mysql2.git
+ revision: 4d76557499b762d5a62aebb7f6a56510ad221eab
+ specs:
+ mysql2 (0.4.0)
@sodabrew
sodabrew Sep 8, 2015 Contributor

Err, this is the release version of 0.4.0, can you drop the git reference then?

@sodabrew sodabrew commented on the diff Sep 8, 2015
...b/active_record/connection_adapters/mysql2_adapter.rb
@@ -1,6 +1,6 @@
require 'active_record/connection_adapters/abstract_mysql_adapter'
-gem 'mysql2', '~> 0.3.18'
+gem 'mysql2', '>= 0.3.18', '< 0.5'
@sodabrew
sodabrew Sep 8, 2015 Contributor

Could you backport this to prior Rails releases?

@sodabrew
Contributor
sodabrew commented Sep 8, 2015

@jeremy Added a few comments post-merge, we can pick this or another issue to follow-up on :)

@jeremy
Member
jeremy commented Sep 8, 2015

The github ref is because it was just before you pushed a gem :) Will
update. Backporting should be fine.
On Tue, Sep 8, 2015 at 03:27 Aaron Stone notifications@github.com wrote:

@jeremy https://github.com/jeremy Added a few comments post-merge, we
can pick this or another issue to follow-up on :)


Reply to this email directly or view it on GitHub
#21536 (comment).

@drench drench referenced this pull request in tablexi/nucore-open Nov 2, 2015
Merged

Gemfile updates #382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment