Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mysql2 0.4.0, first release with prepared statements support #21536

Merged
merged 1 commit into from Sep 8, 2015

Conversation

Projects
None yet
5 participants
@jeremy
Copy link
Member

commented Sep 7, 2015

Broadens AR gem requirement from ~> 0.3.18 to >= 0.3.18, < 0.5

Known failure on Ruby 2.3/trunk: brianmario/mysql2#671

@rails-bot

This comment has been minimized.

Copy link

commented Sep 7, 2015

r? @carlosantoniodasilva

(@rails-bot has picked a reviewer for you, use r? to override)

@jeremy

This comment has been minimized.

Copy link
Member Author

commented Sep 8, 2015

Unrelated build failure with SassImporter: https://travis-ci.org/rails/rails/jobs/79201176#L841-L842

@rafaelfranca

This comment has been minimized.

Copy link
Member

commented Sep 8, 2015

Yeah. Already working in a fix.

@rafaelfranca

This comment has been minimized.

Copy link
Member

commented Sep 8, 2015

Fixed

@rafaelfranca

This comment has been minimized.

Copy link
Member

commented Sep 8, 2015

:shipit:

jeremy added a commit that referenced this pull request Sep 8, 2015

Merge pull request #21536 from jeremy/support-mysql2-0.4.0
Support mysql2 0.4.0, first release with prepared statements support

@jeremy jeremy merged commit 81dd387 into rails:master Sep 8, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jeremy jeremy deleted the jeremy:support-mysql2-0.4.0 branch Sep 8, 2015

@@ -90,7 +90,7 @@ platforms :ruby do
group :db do
gem 'pg', '>= 0.18.0'
gem 'mysql', '>= 2.9.0'
gem 'mysql2', '>= 0.3.18'
gem 'mysql2', '>= 0.4.0', github: 'brianmario/mysql2'

This comment has been minimized.

Copy link
@sodabrew

sodabrew Sep 8, 2015

Contributor

Is the github reference required so that ruby-head tests pass?

remote: git://github.com/brianmario/mysql2.git
revision: 4d76557499b762d5a62aebb7f6a56510ad221eab
specs:
mysql2 (0.4.0)

This comment has been minimized.

Copy link
@sodabrew

sodabrew Sep 8, 2015

Contributor

Err, this is the release version of 0.4.0, can you drop the git reference then?

@@ -1,6 +1,6 @@
require 'active_record/connection_adapters/abstract_mysql_adapter'

gem 'mysql2', '~> 0.3.18'
gem 'mysql2', '>= 0.3.18', '< 0.5'

This comment has been minimized.

Copy link
@sodabrew

sodabrew Sep 8, 2015

Contributor

Could you backport this to prior Rails releases?

@sodabrew

This comment has been minimized.

Copy link
Contributor

commented Sep 8, 2015

@jeremy Added a few comments post-merge, we can pick this or another issue to follow-up on :)

@jeremy

This comment has been minimized.

Copy link
Member Author

commented Sep 8, 2015

The github ref is because it was just before you pushed a gem :) Will
update. Backporting should be fine.
On Tue, Sep 8, 2015 at 03:27 Aaron Stone notifications@github.com wrote:

@jeremy https://github.com/jeremy Added a few comments post-merge, we
can pick this or another issue to follow-up on :)


Reply to this email directly or view it on GitHub
#21536 (comment).

@drench drench referenced this pull request Nov 2, 2015

Merged

Gemfile updates #382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.