Do not dump a view as a table in sqlite3, mysql and mysql2 adapters#21609
Merged
jeremy merged 2 commits intorails:masterfrom Sep 19, 2015
Merged
Do not dump a view as a table in sqlite3, mysql and mysql2 adapters#21609jeremy merged 2 commits intorails:masterfrom
jeremy merged 2 commits intorails:masterfrom
Conversation
Now in sqlite3, mysql and mysql2 adapters, SchemaDumper dump a view as a table. It is incorrect behavior. This change excludes a view in schema.rb.
|
r? @kaspth (@rails-bot has picked a reviewer for you, use r? to override) |
Contributor
|
@kamipo Thanks! BTW maybe Rails team say you "to squash commits" :) |
Contributor
|
This PR looks good to me:) All type of adapters should return array of views, so define I want to use |
jeremy
added a commit
that referenced
this pull request
Sep 19, 2015
Do not dump a view as a table in sqlite3, mysql and mysql2 adapters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related with #21601.
Now in sqlite3, mysql and mysql2 adapters, SchemaDumper dump a view as
a table. It is incorrect behavior. This change excludes a view in schema.rb.