New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not dump a view as a table in sqlite3, mysql and mysql2 adapters #21609

Merged
merged 2 commits into from Sep 19, 2015

Conversation

Projects
None yet
6 participants
@kamipo
Member

kamipo commented Sep 13, 2015

Related with #21601.

Now in sqlite3, mysql and mysql2 adapters, SchemaDumper dump a view as
a table. It is incorrect behavior. This change excludes a view in schema.rb.

kamipo added some commits Sep 13, 2015

Do not dump a view as a table in sqlite3, mysql and mysql2 adapters
Now in sqlite3, mysql and mysql2 adapters, SchemaDumper dump a view as
a table. It is incorrect behavior. This change excludes a view in
schema.rb.
@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Sep 13, 2015

r? @kaspth

(@rails-bot has picked a reviewer for you, use r? to override)

rails-bot commented Sep 13, 2015

r? @kaspth

(@rails-bot has picked a reviewer for you, use r? to override)

@yui-knk

This comment has been minimized.

Show comment
Hide comment
@yui-knk

yui-knk Sep 13, 2015

Contributor

@kamipo Thanks! BTW maybe Rails team say you "to squash commits" :)

Contributor

yui-knk commented Sep 13, 2015

@kamipo Thanks! BTW maybe Rails team say you "to squash commits" :)

@yui-knk

This comment has been minimized.

Show comment
Hide comment
@yui-knk

yui-knk Sep 14, 2015

Contributor

This PR looks good to me:)

All type of adapters should return array of views, so define views method as an interface is reasonable.
And only SchemaDumper#tables cares connection.views is also good! because Adapter#tables should care about views is discussed on #21601.

I want to use views method to implement tables(views: bool), so please merge this before #21601 is merged.

Contributor

yui-knk commented Sep 14, 2015

This PR looks good to me:)

All type of adapters should return array of views, so define views method as an interface is reasonable.
And only SchemaDumper#tables cares connection.views is also good! because Adapter#tables should care about views is discussed on #21601.

I want to use views method to implement tables(views: bool), so please merge this before #21601 is merged.

@senny senny added the activerecord label Sep 14, 2015

@senny senny self-assigned this Sep 14, 2015

@jeremy jeremy merged commit ad4654f into rails:master Sep 19, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jeremy added a commit that referenced this pull request Sep 19, 2015

Merge pull request #21609 from kamipo/do_not_dump_view_as_table
Do not dump a view as a table in sqlite3, mysql and mysql2 adapters

@kamipo kamipo deleted the kamipo:do_not_dump_view_as_table branch Sep 20, 2015

@yahonda yahonda referenced this pull request Nov 11, 2015

Merged

Support `#views` #738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment