Replaced ThreadSafe::Map with successor Concurrent::Map. - #21679
Merged
Conversation
The thread_safe gem is being deprecated and all its code has been merged into the concurrent-ruby gem. The new class, Concurrent::Map, is exactly the same as its predecessor except for fixes to two bugs discovered during the merge.
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
kaspth
added a commit
that referenced
this pull request
Sep 19, 2015
Replaced `ThreadSafe::Map` with successor `Concurrent::Map`.
Contributor
|
Sweet 😁 Loved the PR description too, made for an easy review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
thread_safegem is being deprecated and all its code has been merged intoconcurrent-ruby. The new class,Concurrent::Map, is exactly the same as its predecessor except for fixes to two bugs discovered during the merge.This merge was first discussed with @tenderlove in PR #20866.
This PR depends on a pre-release version of concurrent-ruby (1.0.0.pre2). The original merge of thread_safe happened in 1.0.0.pre1. We will release 1.0.0 before Rails 5 is released. We are not adding new features, just working on performance improvements, better documentation, and other chores. We will schedule a 1.0.0 release date as soon as the Rails team needs us to.
When running the tests there are a few interpreter warnings coming from concurrent-ruby. We will clean those up before the next release. We have an issue open here.