Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Replaced `ThreadSafe::Map` with successor `Concurrent::Map`. #21679
This PR depends on a pre-release version of concurrent-ruby (1.0.0.pre2). The original merge of thread_safe happened in 1.0.0.pre1. We will release 1.0.0 before Rails 5 is released. We are not adding new features, just working on performance improvements, better documentation, and other chores. We will schedule a 1.0.0 release date as soon as the Rails team needs us to.
When running the tests there are a few interpreter warnings coming from concurrent-ruby. We will clean those up before the next release. We have an issue open here.
The thread_safe gem is being deprecated and all its code has been merged into the concurrent-ruby gem. The new class, Concurrent::Map, is exactly the same as its predecessor except for fixes to two bugs discovered during the merge.
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.