Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced `ThreadSafe::Map` with successor `Concurrent::Map`. #21679

Merged
merged 1 commit into from Sep 19, 2015

Conversation

@jdantonio
Copy link
Contributor

jdantonio commented Sep 19, 2015

The thread_safe gem is being deprecated and all its code has been merged into concurrent-ruby. The new class, Concurrent::Map, is exactly the same as its predecessor except for fixes to two bugs discovered during the merge.

This merge was first discussed with @tenderlove in PR #20866.

This PR depends on a pre-release version of concurrent-ruby (1.0.0.pre2). The original merge of thread_safe happened in 1.0.0.pre1. We will release 1.0.0 before Rails 5 is released. We are not adding new features, just working on performance improvements, better documentation, and other chores. We will schedule a 1.0.0 release date as soon as the Rails team needs us to.

When running the tests there are a few interpreter warnings coming from concurrent-ruby. We will clean those up before the next release. We have an issue open here.

The thread_safe gem is being deprecated and all its code has been merged
into the concurrent-ruby gem. The new class, Concurrent::Map, is exactly
the same as its predecessor except for fixes to two bugs discovered
during the merge.
@rails-bot
Copy link

rails-bot commented Sep 19, 2015

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

kaspth added a commit that referenced this pull request Sep 19, 2015
Replaced `ThreadSafe::Map` with successor `Concurrent::Map`.
@kaspth kaspth merged commit 1bf3cec into rails:master Sep 19, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kaspth
Copy link
Member

kaspth commented Sep 19, 2015

Sweet 😁

Loved the PR description too, made for an easy review!

@jdantonio jdantonio deleted the jdantonio:replace-thread-safe branch Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.