Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Mailer preview request model #21702
Ability to pass Rails::MailersControlle params to ActionMailer::Preview instances (e.g. MyMailerPreview)
....I'm sorry, I've manage to screw-up upstream rebase of my original Pull request Mailer preview request model so here is the same PR updated with latest upstream
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
I think if we were going to do anything we'd add a
class OrderMailerPreview < ActionMailer::Preview def receipt OrderMailer.receipt(Order.find(params[:id])) end end
I think anything else is straying too far into application level concerns.