Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix #first(limit) to take advantage of #loaded? records if available #22053
I realized that
changed the title from
Fix `first(limit)` to take advantage of `loaded?` records if available
Fix #first(limit) to take advantage of loaded? records if available
Oct 23, 2015
@senny Made the changes you suggested - note
@Empact It's not necessary to make a PR for the removal. Once we release a new Major or Minor version we go through all deprecations and remove the ones that are due. Usually they stay for one release cycle. Meaning that the option will be deprecated in 5.0 and will be removed from 5.1.
added a commit
this pull request
Dec 28, 2015
There is some inconsistency here: you should warn unconditionally about offset deprecation. In current implementation if I would do:
u = User.where(...) u.to_a u.find_nth(77, 15)
I would not see a deprecation warning.