Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enabled flag to the public file server settings. #22173

Merged
merged 2 commits into from Nov 4, 2015

Conversation

@kaspth
Copy link
Member

@kaspth kaspth commented Nov 3, 2015

As discussed in #19135 (comment).

Replaces serve_static_files to unify the static options under the public_file_server wing.

Deprecates serve_static_files accessors, but make them use the newer config internally.

As discussed in #19135 (comment).

Replaces `serve_static_files` to unify the static options under the `public_file_server` wing.

Deprecates `serve_static_files` accessors, but make them use the newer config internally.
@rafaelfranca
Copy link
Member

@rafaelfranca rafaelfranca commented Nov 3, 2015

:shipit:

@kaspth
Copy link
Member Author

@kaspth kaspth commented Nov 3, 2015

Sweet! Will ship it in the morning, don't want to accidentally leave the build broken overnight 😁

Also planning of pulling over one of the original changelog entries to Railties: #19135 (comment)

@schneems
Copy link
Member

@schneems schneems commented Nov 3, 2015

Since we've got 3 different flags for this now. Can we make a different flag for assuming the public folder won't change after boot so we can effectively cache all files at start up and not have to hit disk on every request?

The configuration for `config.static_cache_control`, and its replacement
`config.public_file_server.headers` are implemented in Railties.

People would configure this in environment files, which is Railties domain too.
kaspth added a commit that referenced this pull request Nov 4, 2015
Add enabled flag to the public file server settings.
@kaspth kaspth merged commit 7b471db into rails:master Nov 4, 2015
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kaspth kaspth deleted the kaspth:enable-public-file-server branch Nov 4, 2015
@kaspth
Copy link
Member Author

@kaspth kaspth commented Nov 4, 2015

@schneems yeah, that sounds cool!

Could add an eager_load option to config.public_file_server, which just mimics config.eager_load by default.

@rafaelfranca rafaelfranca modified the milestones: 5.0.0 [temp], 5.0.0 Dec 30, 2015
shamozhixing pushed a commit to shamozhixing/gitlab-ce that referenced this pull request Aug 23, 2016
…ions.

Deprecation of static_cache_control: rails/rails#19135

Deprecation of serve_static_files: rails/rails#22173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.