Add enabled flag to the public file server settings. - #22173
Merged
Conversation
As discussed in rails#19135 (comment). Replaces `serve_static_files` to unify the static options under the `public_file_server` wing. Deprecates `serve_static_files` accessors, but make them use the newer config internally.
Member
|
|
Contributor
Author
|
Sweet! Will ship it in the morning, don't want to accidentally leave the build broken overnight 😁 Also planning of pulling over one of the original changelog entries to Railties: #19135 (comment) |
Member
|
Since we've got 3 different flags for this now. Can we make a different flag for assuming the public folder won't change after boot so we can effectively cache all files at start up and not have to hit disk on every request? |
The configuration for `config.static_cache_control`, and its replacement `config.public_file_server.headers` are implemented in Railties. People would configure this in environment files, which is Railties domain too.
kaspth
added a commit
that referenced
this pull request
Nov 4, 2015
Add enabled flag to the public file server settings.
Contributor
Author
|
@schneems yeah, that sounds cool! Could add an |
shamozhixing
pushed a commit
to shamozhixing/gitlab-ce
that referenced
this pull request
Aug 23, 2016
…ions. Deprecation of static_cache_control: rails/rails#19135 Deprecation of serve_static_files: rails/rails#22173
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #19135 (comment).
Replaces
serve_static_filesto unify the static options under thepublic_file_serverwing.Deprecates
serve_static_filesaccessors, but make them use the newer config internally.