send normalized keys to the cache backends so they do not need to man…

[grosser]

…age this themselves

key manipulation is a recurring pattern in the cache stores (base + file + mem_cached) which makes the code less readable and mixes concerns

this moves all the key manipulation into a single method normalize_key and reuses that, which will also enable users to inherit or share logic better via modules since they no longer have to modify the key (escape_key or key_file_path or namespaced_key)

[grosser]

cleaning this up ... passes amount but it is not being used ...

[grosser]

@kaspth another one ... this did not get assigned to anyone ...

[jeremy]

API changes break any non-core cache store subclasses that override or call these methods.

[grosser]

so leave the method as namespaced_key so nobody that calls super gets hurt ?

[jeremy]

And the callers of any of the methods that now require a namespaced/normalized key argument.

[grosser]

Only private methods were changes, so this would only affect
users that do Rails.cache.send(:read_entry) ...

On Mon, Nov 9, 2015 at 8:51 PM, Jeremy Daer notifications@github.com
wrote:

And the callers of any of the methods that now require a
namespaced/normalized key argument.

—
Reply to this email directly or view it on GitHub
#22215 (comment).

[jeremy]

The consumers of these API are other cache store subclasses. They call or super() to these boilerplate methods.

[grosser]

so they would still work fine when renamed to normalize_parameters, right ?

[grosser]

I added an alias for the old method, so there should be no fallout ... good to go ?

[grosser]

rebased

@jeremy looking good ?

[grosser]

@rafaelfranca got 2 cents on that ?

[grosser]

@jeremy / @kaspth / @rafaelfranca ok to merge this ?

[rafaelfranca]

The API is being maintained by the alias so I think it is good. Thanks

[kaspth]

This doesn't cover backwards compatibility. The file and mem cache stores changes break user written subclasses.

[grosser]

user written subclasses of stores, not Cache itself, right ?

[kaspth]

Missed the conversation going on in #22205 (comment). Backing off 🤘