It should be possible to use ActiveSupport::DescendantTracker without ActiveSupport::Dependencies #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… getting ActiveSupport::Dependencies for free.
|
Looks good to me. |
|
Applied. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ActiveSupport::DescendantTracker depends on ActiveSupport::Dependencies. That does not really make sense, since it is only used in the
clearmethod.AS::Callbacks depends on AS::DescendantTracker, but never calls the clear method. It should be possible to use AS::Callbacks without getting AS::Dependencies for free. Especially since AS::Dependencies overrides a few Ruby core methods.
This patch checks for the presence of AS::Dependencies when clearing the DescendantTracker and removes the explicit dependency.