It should be possible to use ActiveSupport::DescendantTracker without ActiveSupport::Dependencies #223

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

Currently, ActiveSupport::DescendantTracker depends on ActiveSupport::Dependencies. That does not really make sense, since it is only used in the clear method.

AS::Callbacks depends on AS::DescendantTracker, but never calls the clear method. It should be possible to use AS::Callbacks without getting AS::Dependencies for free. Especially since AS::Dependencies overrides a few Ruby core methods.

This patch checks for the presence of AS::Dependencies when clearing the DescendantTracker and removes the explicit dependency.

Rolf Timmermans It should be possible to use ActiveSupport::DescendantTracker without…
… getting ActiveSupport::Dependencies for free.
5948415
Member

josevalim commented Mar 12, 2011

Looks good to me.

Member

josevalim commented Mar 12, 2011

Applied.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment