Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Adding test case for request.url in engine mounted at root (#2131) #2230

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Owner

guilleiguaran commented Jul 24, 2011

I'm looking to fix #2131 but I don't sure about how to do it. I've added a test case for the error described in the issue.

The test is this:

test "request url for controller action when engine is mounted at root" do
  get "/weblog"
  assert_equal "http://example.org/weblog", last_response.body
end

last_response.body (request.url) must be equal to "http://example.org/weblog" but it's "http://example.org//weblog"

Any ideas to solve it?

@rails-noob rails-noob pushed a commit to rails-noob/rails that referenced this pull request Sep 6, 2011

rails-noob Remove failing test from pull request #2230. 0ff27fa

@jonleighton jonleighton added a commit that referenced this pull request Sep 8, 2011

@jonleighton jonleighton Remove failing test which was wrongly introduced.
This test was introduced in pull request #2577. The author of the pull
request included the test, which was originally in #2230, at the same
time as fixing a separate (but related) bug. However, the author did not
include a fix for this test, so when #2577 was merged, a failing test
was introduced.

So I am removing the failing test for now. If anyone wants to fix the
bug, please do so and submit a complete pull request with a test and
a fix.
562277b

@jonleighton jonleighton added a commit that referenced this pull request Sep 8, 2011

@jonleighton jonleighton Remove failing test which was wrongly introduced.
This test was introduced in pull request #2577. The author of the pull
request included the test, which was originally in #2230, at the same
time as fixing a separate (but related) bug. However, the author did not
include a fix for this test, so when #2577 was merged, a failing test
was introduced.

So I am removing the failing test for now. If anyone wants to fix the
bug, please do so and submit a complete pull request with a test and
a fix.
04baa4b
Owner

pixeltrix commented Mar 12, 2012

Fixed by this commit to Journey

@pixeltrix pixeltrix closed this Mar 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment