New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema dumping support for PostgreSQL geometric data types #22304

Merged
merged 2 commits into from Nov 24, 2015

Conversation

Projects
None yet
4 participants
@kamipo
Member

kamipo commented Nov 15, 2015

No description provided.

@rails-bot

This comment has been minimized.

rails-bot commented Nov 15, 2015

r? @pixeltrix

(@rails-bot has picked a reviewer for you, use r? to override)

@kamipo kamipo force-pushed the kamipo:schema_dumping_support_for_postgresql_geometric_types branch Nov 16, 2015

@kamipo kamipo force-pushed the kamipo:schema_dumping_support_for_postgresql_geometric_types branch Nov 16, 2015

@senny senny assigned senny and unassigned pixeltrix Nov 16, 2015

@senny

View changes

activerecord/test/cases/adapters/postgresql/geometric_test.rb Outdated
g.save!
h = PostgresqlGeometric.find(g.id)
assert_equal '{1.5,-1,0}', h.a_line if supports_line?

This comment has been minimized.

@senny

senny Nov 16, 2015

Member

Can we put stuff about the line type in a separate test? I don't like how supports_line? is spread all over this test.

@senny

This comment has been minimized.

Member

senny commented Nov 16, 2015

@kamipo just a minor note. Otherwise this is looking good. Can we close #22188 in favor of this PR?

@kamipo kamipo force-pushed the kamipo:schema_dumping_support_for_postgresql_geometric_types branch Nov 16, 2015

@kamipo

This comment has been minimized.

Member

kamipo commented Nov 16, 2015

Fixed the line type test in a separate test. I'll close #22188, thanks!

@senny

This comment has been minimized.

Member

senny commented Nov 21, 2015

@kamipo this looks good, can you push a rebased version?

@senny

View changes

activerecord/test/cases/adapters/postgresql/geometric_test.rb Outdated
t.column :a_path, :path
t.column :a_polygon, :polygon
t.column :a_circle, :circle
t.line :a_line

This comment has been minimized.

@senny

senny Nov 21, 2015

Member

Does this line type not follow the same restrictions for PostgreSQL version? I think we should check the dump in PostgreSQLGeometricLineTest as well and remove that from here.

@kamipo kamipo force-pushed the kamipo:schema_dumping_support_for_postgresql_geometric_types branch to 3991ebc Nov 23, 2015

@kamipo

This comment has been minimized.

Member

kamipo commented Nov 23, 2015

I moved all line type tests to PostgreSQLGeometricLineTest.

senny added a commit that referenced this pull request Nov 24, 2015

Merge pull request #22304 from kamipo/schema_dumping_support_for_post…
…gresql_geometric_types

Add schema dumping support for PostgreSQL geometric data types

@senny senny merged commit 9feeaab into rails:master Nov 24, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@senny

This comment has been minimized.

Member

senny commented Nov 24, 2015

@kamipo thank you 💛

@kamipo kamipo deleted the kamipo:schema_dumping_support_for_postgresql_geometric_types branch Nov 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment