New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest byebug #22328

Merged
merged 1 commit into from Nov 18, 2015

Conversation

Projects
None yet
5 participants
@k0kubun
Contributor

k0kubun commented Nov 18, 2015

Since my patch for byebug deivid-rodriguez/byebug#160 which is released in byebug 7.0 improved the debugging performance about 10x faster, I want Rails maintainers to use the latest byebug for debugging Rails and save your time.

@rails-bot

This comment has been minimized.

rails-bot commented Nov 18, 2015

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kaspth

This comment has been minimized.

Member

kaspth commented Nov 18, 2015

Badass work ❤️

kaspth added a commit that referenced this pull request Nov 18, 2015

@kaspth kaspth merged commit ce37df9 into rails:master Nov 18, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@k0kubun k0kubun deleted the k0kubun:upgrade-byebug branch Nov 18, 2015

@k0kubun

This comment has been minimized.

Contributor

k0kubun commented Nov 18, 2015

Thank you :)

@jeremy

This comment has been minimized.

Member

jeremy commented Dec 8, 2015

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment