Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `assert_recognizes` to traverse mounted engines #22435

Merged
merged 1 commit into from Nov 6, 2017

Conversation

Projects
None yet
7 participants
@yui-knk
Copy link
Contributor

yui-knk commented Nov 28, 2015

Before this commit paths of mounted engines are not traversed
when assert_recognizes is called, causing strange test results.
This commit enable to traverse mounted paths.

@rails-bot

This comment has been minimized.

Copy link

rails-bot commented Nov 28, 2015

r? @senny

(@rails-bot has picked a reviewer for you, use r? to override)

@senny

This comment has been minimized.

Copy link
Member

senny commented Nov 30, 2015

@rails-bot rails-bot assigned pixeltrix and unassigned senny Nov 30, 2015

@senny senny added the actionpack label Nov 30, 2015

@senny

This comment has been minimized.

Copy link
Member

senny commented Nov 30, 2015

Maybe related to #8294.

@yui-knk

This comment has been minimized.

Copy link
Contributor Author

yui-knk commented Dec 1, 2015

If necessary I will write ChangeLog (sorry I overlooked bug report).

@maclover7

This comment has been minimized.

Copy link
Member

maclover7 commented Feb 17, 2016

I think this might also solve an issue with assert_routing... Can you try and add some assert_routing tests on a Rack-mounted app?

@maclover7

This comment has been minimized.

Copy link
Member

maclover7 commented Apr 20, 2016

@yui-knk can you rebase this?

@yui-knk yui-knk force-pushed the yui-knk:fix_engine_route_test branch to b50e88e Apr 23, 2016

@yui-knk

This comment has been minimized.

Copy link
Contributor Author

yui-knk commented Apr 23, 2016

@maclover7 rebased! 😍

Make `assert_recognizes` to traverse mounted engines
Before this commit paths of mounted engines are not traversed
when `assert_recognizes` is called, causing strange test results.
This commit enable to traverse mounted paths.
@mikker

This comment has been minimized.

Copy link
Contributor

mikker commented Nov 6, 2017

Should this have been merged? Or bump as they say.

@rafaelfranca rafaelfranca merged commit b50e88e into rails:master Nov 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

rafaelfranca added a commit that referenced this pull request Nov 6, 2017

Merge pull request #22435 from yui-knk/fix_engine_route_test
Make `assert_recognizes` to traverse mounted engines

@bquorning bquorning referenced this pull request Dec 13, 2017

Merged

Rails 5.2 #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.