New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of minitest-rails gem with test runner #22456

Merged
merged 1 commit into from Nov 30, 2015

Conversation

Projects
None yet
5 participants
@chriskottom
Contributor

chriskottom commented Nov 30, 2015

Add explicit global namespace to Rails::TestUnitReporter to resolve a namespace conflict between minitest-rails and Rails test runner. Fixes #22455.

@rails-bot

This comment has been minimized.

rails-bot commented Nov 30, 2015

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @matthewd (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

sgrif added a commit that referenced this pull request Nov 30, 2015

Merge pull request #22456 from chriskottom/fix-minitest-plugin-with-m…
…initest-rails-gem

Allow use of minitest-rails gem with test runner

@sgrif sgrif merged commit 404597b into rails:master Nov 30, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kaspth

This comment has been minimized.

Member

kaspth commented Nov 30, 2015

Ah, sorry for letting that slip back in. Thanks for the fix 😁

@chriskottom chriskottom deleted the chriskottom:fix-minitest-plugin-with-minitest-rails-gem branch Nov 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment