New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails command infrastructure #22457

Merged
merged 1 commit into from Dec 4, 2015

Conversation

Projects
None yet
7 participants
@ccallebs
Contributor

ccallebs commented Nov 30, 2015

Corollary of #21254. Isolates command infrastructure and reduces sprawl of previous PR.

@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Nov 30, 2015

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @arthurnn (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rails-bot commented Nov 30, 2015

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @arthurnn (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kaspth kaspth assigned kaspth and unassigned arthurnn Dec 1, 2015

@kaspth kaspth added this to the 5.0.0 milestone Dec 1, 2015

@kaspth

View changes

Show outdated Hide outdated railties/lib/rails/commands/command.rb
@kaspth

View changes

Show outdated Hide outdated railties/lib/rails/commands/command.rb
@kaspth

View changes

Show outdated Hide outdated railties/lib/rails/commands/command.rb
@kaspth

View changes

Show outdated Hide outdated railties/lib/rails/commands/command.rb
@kaspth

View changes

Show outdated Hide outdated railties/lib/rails/commands/command.rb
@kaspth

View changes

Show outdated Hide outdated railties/lib/rails/commands/command.rb
@kaspth

View changes

Show outdated Hide outdated railties/lib/rails/commands/command.rb
@kaspth

View changes

Show outdated Hide outdated railties/lib/rails/commands/command.rb
@kaspth

View changes

Show outdated Hide outdated railties/lib/rails/commands/command.rb
@kaspth

This comment has been minimized.

Show comment
Hide comment
@kaspth

kaspth Dec 1, 2015

Member

Don't worry about the documentation for now, I'll write it after this is merged.

We also need some tests for the general functionality here. Some simple integration tests modeled after https://github.com/rails/rails/blob/master/railties/test/application/test_runner_test.rb would do.

The helpers you'll need are here: https://github.com/rails/rails/blob/master/railties/test/isolation/abstract_unit.rb

Member

kaspth commented Dec 1, 2015

Don't worry about the documentation for now, I'll write it after this is merged.

We also need some tests for the general functionality here. Some simple integration tests modeled after https://github.com/rails/rails/blob/master/railties/test/application/test_runner_test.rb would do.

The helpers you'll need are here: https://github.com/rails/rails/blob/master/railties/test/isolation/abstract_unit.rb

@kaspth

This comment has been minimized.

Show comment
Hide comment
@kaspth

kaspth Dec 1, 2015

Member

Also thanks for working on this! ❤️

Member

kaspth commented Dec 1, 2015

Also thanks for working on this! ❤️

@ccallebs

This comment has been minimized.

Show comment
Hide comment
@ccallebs

ccallebs Dec 1, 2015

Contributor

@kaspth No problem! Sorry it's taken so long, and I appreciate the patience.

Contributor

ccallebs commented Dec 1, 2015

@kaspth No problem! Sorry it's taken so long, and I appreciate the patience.

@ccallebs

View changes

Show outdated Hide outdated railties/test/commands/command_test.rb
@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca
Member

rafaelfranca commented Dec 4, 2015

r? @kaspth

@kaspth

View changes

Show outdated Hide outdated railties/lib/rails/commands/command.rb
@kaspth

This comment has been minimized.

Show comment
Hide comment
@kaspth

kaspth Dec 4, 2015

Member

@ccallebs we don't have much time left to get this in. Please address my last comments as soon as you can and squash your commits down to one. Then I'll merge and we can start transforming more tasks to commands ❤️

Member

kaspth commented Dec 4, 2015

@ccallebs we don't have much time left to get this in. Please address my last comments as soon as you can and squash your commits down to one. Then I'll merge and we can start transforming more tasks to commands ❤️

@ccallebs

This comment has been minimized.

Show comment
Hide comment
@ccallebs

ccallebs Dec 4, 2015

Contributor

@kaspth Will do, just had one more question. Anything more will be addressed today, I won't let this linger any longer.

Contributor

ccallebs commented Dec 4, 2015

@kaspth Will do, just had one more question. Anything more will be addressed today, I won't let this linger any longer.

@ccallebs

This comment has been minimized.

Show comment
Hide comment
@ccallebs

ccallebs Dec 4, 2015

Contributor

@kaspth Everything is addressed and squashed! Let me know if you need anything else. I'll jump in to help with some of the other commands once this is merged.

Contributor

ccallebs commented Dec 4, 2015

@kaspth Everything is addressed and squashed! Let me know if you need anything else. I'll jump in to help with some of the other commands once this is merged.

kaspth added a commit that referenced this pull request Dec 4, 2015

@kaspth kaspth merged commit 6616724 into rails:master Dec 4, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kaspth

This comment has been minimized.

Show comment
Hide comment
@kaspth

kaspth Dec 4, 2015

Member

Awesome work! ❤️

Member

kaspth commented Dec 4, 2015

Awesome work! ❤️

@ccallebs

This comment has been minimized.

Show comment
Hide comment
@ccallebs

ccallebs Dec 4, 2015

Contributor

@kaspth It's been a long crazy trip! :)

Contributor

ccallebs commented Dec 4, 2015

@kaspth It's been a long crazy trip! :)

@kaspth

This comment has been minimized.

Show comment
Hide comment
@kaspth

kaspth Dec 4, 2015

Member

And we ain't out of the woods yet ;)

Member

kaspth commented Dec 4, 2015

And we ain't out of the woods yet ;)

test 'dev:cache deletes file and outputs message' do
Dir.chdir(app_path) do
output = `rails dev:cache`

This comment has been minimized.

@ybart

ybart Dec 7, 2015

This assignation is unneeded

@ybart

ybart Dec 7, 2015

This assignation is unneeded

This comment has been minimized.

@josephgrossberg

josephgrossberg Dec 7, 2015

Duplicate line, yes?

@josephgrossberg

josephgrossberg Dec 7, 2015

Duplicate line, yes?

This comment has been minimized.

@kaspth

kaspth Dec 7, 2015

Member

Cleared it up with some comments: 2af9c08 😁

@kaspth

kaspth Dec 7, 2015

Member

Cleared it up with some comments: 2af9c08 😁

@rafaelfranca rafaelfranca modified the milestones: 5.0.0 [temp], 5.0.0 Dec 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment