Make polymorphic_url calls go through application helpers again. #2252

Merged
merged 1 commit into from Jul 25, 2011

Conversation

Projects
None yet
2 participants
@thedarkone
Contributor

thedarkone commented Jul 25, 2011

This brings back the ability to overwrite/extend polymorphic url helpers via application helpers that was present in Rails 2.3 and Rails 3.0.

Thus allowing to do something like this:

module ApplicationHelper
  def posts_path(*args)
    do_something(*args)
    super
  end
end
Make polymorphic_url calls go through application helpers again.
This brings back the ability to overwrite/extend url generating methods in application heleprs.

josevalim added a commit that referenced this pull request Jul 25, 2011

Merge pull request #2252 from thedarkone/polymorphic-url-helpers
Make polymorphic_url calls go through application helpers again.

@josevalim josevalim merged commit dffd920 into rails:master Jul 25, 2011

@josevalim

This comment has been minimized.

Show comment
Hide comment
@josevalim

josevalim Jul 25, 2011

Contributor

Is this broken on 3-1-stable as well? If so, could you please backport? Thanks!

Contributor

josevalim commented Jul 25, 2011

Is this broken on 3-1-stable as well? If so, could you please backport? Thanks!

@thedarkone

This comment has been minimized.

Show comment
Hide comment
@thedarkone

thedarkone Jul 25, 2011

Contributor

This applies cleanly to 3-1-stable as well. Do I need to open another pull request?

Contributor

thedarkone commented Jul 25, 2011

This applies cleanly to 3-1-stable as well. Do I need to open another pull request?

@josevalim

This comment has been minimized.

Show comment
Hide comment
@josevalim

josevalim Jul 25, 2011

Contributor

Yes please ( I am in a computer without git :( ).

Contributor

josevalim commented Jul 25, 2011

Yes please ( I am in a computer without git :( ).

josevalim added a commit that referenced this pull request Jul 25, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment