Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionMailer: support overriding template name in multipart #22534

Merged
merged 1 commit into from Nov 20, 2018

Conversation

Projects
None yet
8 participants
@milgner
Copy link
Contributor

commented Dec 8, 2015

Implicit rendering in multipart blocks now also uses the template name from the options hash instead of always using the action name.

So you can now write

mail(template_name: template_name) do |format|
  format.text
  format.html
end
ActionMailer: support overriding template name in multipart
Implicit rendering in multipart blocks now also uses the template
name from the options hash instead of always using the action name.

So you can now write

    mail(template_name: template_name) do |format|
      format.text
      format.html
    end
@rails-bot

This comment has been minimized.

Copy link

commented Dec 8, 2015

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @matthewd (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rafaelfranca

This comment has been minimized.

Copy link
Member

commented Dec 8, 2015

Related with #22045. Same as #18412

@dijonkitchen

This comment has been minimized.

Copy link
Contributor

commented Jan 21, 2017

Can this be closed since #18412 is closed for not being compelling enough?

@vipulnsward

This comment has been minimized.

Copy link
Member

commented Jan 21, 2017

cc @sgrif

@rusikf

This comment has been minimized.

Copy link
Contributor

commented Nov 17, 2018

Looks, a good idea, why this pr is not merged?

@rafaelfranca rafaelfranca merged commit 5c54db2 into rails:master Nov 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

rafaelfranca added a commit that referenced this pull request Nov 20, 2018

Merge pull request #22534 from evopark/master
ActionMailer: support overriding template name in multipart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.