Merge Action Cable into master #22586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated from a fresh `bundle install` * Add websocket-driver * Update activesupport * Rename `actioncable` -> `action_cable`
…-error Up[date README sample code so there is no syntax error
ActionCable.server should always return the same instance
Freshen Gemfile.lock
Fix CoffeeScript syntax in code examples
update documentation to use websocket protocol
update README to include creating the ApplicationCabel::Channel
Fix double ` ```ruby ` within the same code block.
README.md code block fix
…xample file for creating App.cable not conflict with the action cable js libs
Update readme instructions for js
celluoid -> celluloid
small typo on README.md
Still missing the stuff in app/ – we need to basically switch from a * match to specifically picking out what we need.
Rack::Server already does it work for us if the server is installed.
Since we require you to enable it on the client-side, let us do the same on the server-side. Then you’re not running an EventMachine unless you need to.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working in a branch so everyone in rails/rails can collaborate.