Deprecate passing string to define callback.

[yui-knk]

No description provided.

[rails-bot]

r? @pixeltrix

(@rails-bot has picked a reviewer for you, use r? to override)

[yui-knk]

ref #22460

[claudiob]

👍 @yui-knk 😄

As part of this commit, I think you should also remove this documentation.

[rafaelfranca]

Maybe we should create a Set so the performance of include? is better?

[nateberkopec]

Hm, looks like creating Sets is too slow. Here's a benchmark. With an Array of 10 elements, creating a Set and then calling #include? is 5x slower than creating an Array and calling #include?

[rafaelfranca]

Yes, creating sets is slow but we are creating only once and we are calling include on every request so it may be worth using Set here.

[rafaelfranca]

Per the size of the Array it will not matter.

[yui-knk]

@nateberkopec Thanks for your help

$ ruby creating_set.rb
Calculating -------------------------------------
         set include    45.093k i/100ms
       array include    15.519k i/100ms
-------------------------------------------------
         set include    713.458k (± 5.0%) i/s -      3.562M
       array include    182.015k (± 4.3%) i/s -    915.621k

Comparison:
         set include:   713457.8 i/s
       array include:   182014.8 i/s - 3.92x slower

[yui-knk]

@rafaelfranca I updatd 😍