New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate passing string to define callback. #22598

Merged
merged 1 commit into from Dec 16, 2015

Conversation

Projects
None yet
7 participants
@yui-knk
Contributor

yui-knk commented Dec 15, 2015

No description provided.

@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Dec 15, 2015

r? @pixeltrix

(@rails-bot has picked a reviewer for you, use r? to override)

rails-bot commented Dec 15, 2015

r? @pixeltrix

(@rails-bot has picked a reviewer for you, use r? to override)

@yui-knk

This comment has been minimized.

Show comment
Hide comment
@yui-knk

yui-knk Dec 15, 2015

Contributor

ref #22460

Contributor

yui-knk commented Dec 15, 2015

ref #22460

@claudiob

This comment has been minimized.

Show comment
Hide comment
@claudiob

claudiob Dec 15, 2015

Member

👍 @yui-knk 😄

As part of this commit, I think you should also remove this documentation.

Member

claudiob commented Dec 15, 2015

👍 @yui-knk 😄

As part of this commit, I think you should also remove this documentation.

@rafaelfranca

View changes

Show outdated Hide outdated actionpack/lib/abstract_controller/callbacks.rb
@yui-knk

This comment has been minimized.

Show comment
Hide comment
@yui-knk

yui-knk Dec 16, 2015

Contributor

@rafaelfranca I updatd 😍

Contributor

yui-knk commented Dec 16, 2015

@rafaelfranca I updatd 😍

rafaelfranca added a commit that referenced this pull request Dec 16, 2015

Merge pull request #22598 from yui-knk/deprecate_string_callback
Deprecate passing string to define callback.

@rafaelfranca rafaelfranca merged commit b7a7e82 into rails:master Dec 16, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kamipo kamipo added the activesupport label Jan 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment