Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring latest changes over from actioncable/master #22600

merged 1 commit into from Dec 15, 2015


Copy link

@javan javan commented Dec 15, 2015

Copy link

@rails-bot rails-bot commented Dec 15, 2015

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Copy link

@rails-bot rails-bot commented Dec 15, 2015

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against merge-action-cable. Please double check that you specified the right target!
dhh added a commit that referenced this pull request Dec 15, 2015
Bring latest changes over from actioncable/master
@dhh dhh merged commit 5b56abb into rails:merge-action-cable Dec 15, 2015
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants