Ensure that app/mailers gets created in new plugins #2287

Merged
merged 1 commit into from Jul 27, 2011

Projects

None yet

2 participants

@dgeb
Contributor
dgeb commented Jul 26, 2011

When calling "rails plugin new [plugin_name] --full", an app/mailers directory was not created in the resultant plugin. This pull request corrects that.

Contributor
dgeb commented Jul 27, 2011

I am puzzled. This commit shows two diffs, yet shows only a single file in the github viewer. My intention was to also include the following directory by committing a .empty_directory file:
https://github.com/dgeb/rails/tree/3-1-mailers-in-plugins/railties/lib/rails/generators/rails/plugin_new/templates/app/mailers

The reason I wanted to include this directory is that it's apparently missing from:
https://github.com/rails/rails/tree/3-1-stable/railties/lib/rails/generators/rails/plugin_new/templates/app

I don't know why this directory and .empty_directory file seem to be missing from this commit. Perhaps it's there and there is a glitch in the github viewer?

Anyway, the point is that this needs to get into 3-1-stable so that the full app structure is available for new plugins. Thanks in advance.

@josevalim josevalim merged commit a9dea60 into rails:3-1-stable Jul 27, 2011
Member

Merged. And yes, probably a github bug.

Contributor
dgeb commented Jul 27, 2011

Looks like the directory made it with the merge, so I guess you're right. Thanks for the merge and the clarification.

Contributor
dgeb commented Jul 28, 2011

@josevalim - looks like this still needs to be merged with master. For future reference, would it have been better for me to target master and then ask you to backport to 3-1-stable?

Member

Yes! Could you please provide a patch for master and ping me? :) Thanks for everything!

Contributor
dgeb commented Jul 29, 2011

@josevalim - Glad to help :) Please see #2339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment