Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `select_values` method signature for consistency #22973

Merged

Conversation

@kamipo
Copy link
Member

kamipo commented Jan 8, 2016

No description provided.

@rails-bot

This comment has been minimized.

Copy link

rails-bot commented Jan 8, 2016

r? @pixeltrix

(@rails-bot has picked a reviewer for you, use r? to override)

@rafaelfranca

This comment has been minimized.

Copy link
Member

rafaelfranca commented Jan 8, 2016

Thank you for the pull request. This signature is to maintain consistence with?

@kamipo

This comment has been minimized.

Copy link
Member Author

kamipo commented Jan 8, 2016

select_one, select_value, and select_rows method signature is (sql, name = nil, binds = []).
select_values is (sql, name = nil). I think it is inconsistent.

@rafaelfranca

This comment has been minimized.

Copy link
Member

rafaelfranca commented Jan 8, 2016

👍, also right now is not possible to pass binds to it.

rafaelfranca added a commit that referenced this pull request Jan 8, 2016
Fix `select_values` method signature for consistency
@rafaelfranca rafaelfranca merged commit 078d86b into rails:master Jan 8, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kamipo kamipo deleted the kamipo:fix_select_values_method_signature branch Jan 8, 2016
kamipo added a commit to kamipo/rails that referenced this pull request Oct 10, 2016
Related rails#22973, rails#24708.

`select_all`, `select_one`, `select_value`, and `select_values` method
signature is `(arel, name = nil, binds = [])`.
But `select_rows` is `(sql, name = nil, binds = [])`.
kamipo added a commit to kamipo/rails that referenced this pull request Jan 3, 2017
Related rails#22973, rails#24708.

`select_all`, `select_one`, `select_value`, and `select_values` method
signature is `(arel, name = nil, binds = [])`.
But `select_rows` is `(sql, name = nil, binds = [])`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.