Use correct timezone when parsing date in json#23011
Use correct timezone when parsing date in json#23011chancancode merged 1 commit intorails:masterfrom
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@arnvald this looks good 👍 Can we add a CHANGELOG entry - thanks. |
35cd28e to
977a408
Compare
|
@pixeltrix thank you! I've rebased the branch and updated changelog |
There was a problem hiding this comment.
@arnvald Newly added CHANGELOG should be added at the top of the file. Please move this entry to the top of CHANGELOG file.
Fixes rails#22171 Time specified in ISO 8601 format without `Z` should be considered as local time, yet until now it was treated as UTC. This commit fixes problem by parsing time using timezone specified in application config. The downside of this solution is performance hit (`Time.zone.parse` is ~ 1.6x slower than `Time.parse`), so maybe there's a better solution.
977a408 to
a3ddd5f
Compare
|
@prathamesh-sonpatki updated, thanks for information! :) |
Use correct timezone when parsing date in json
|
@arnvald omg! so sorry for the delay, I have merged this in 3a9428d @rafaelfranca @sgrif @eileencodes should this be backported to 5-0-0 or 5-0-stable? I would like to get this on 5.0.0 if possible because it is technically a breaking change (the class changed from |
Use correct timezone when parsing date in json
Use correct timezone when parsing date in json
Use correct timezone when parsing date in json
…-to-5-0-0 Backport #23011 to 5-0-0
…-to-5-0-stable Backport #23011 to 5-0-stable
Fixes #22171
Time specified in ISO 8601 format without
Zshould be parsed as local time, yet until now it was treated as UTC.This commit fixes problem by parsing time using timezone specified in application config.
The downside of this solution is performance hit (
Time.zone.parseis ~ 1.6x slower thanTime.parse), so maybe there's a better solution.Additionally,
YYYY-MM-DDformat is parsed asDatenotDateTimeas it was until now (recommended by @pixeltrix #22171 (comment))/cc @maclover7 @pixeltrix @chancancode