Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent static middleware from attempting to serve a request with a null byte #23035

Merged
merged 1 commit into from Jan 12, 2016

Conversation

@jkowens
Copy link
Contributor

jkowens commented Jan 12, 2016

File paths cannot contain null byte characters and methods that do file path operations such as Rack::Utils#clean_path_info will raise unwanted ArgumentError exceptions.

By implementing this change the Static middleware will delegate serving the request to the application stack instead of raising an error and responding with a 500 status. Resolves #22235.

File paths cannot contain null byte characters and methods that do path
operations such as Rack::Utils#clean_path_info will raise unwanted
errors.
@rails-bot

This comment has been minimized.

Copy link

rails-bot commented Jan 12, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rafaelfranca added a commit that referenced this pull request Jan 12, 2016
Prevent static middleware from attempting to serve a request with a null byte
@rafaelfranca rafaelfranca merged commit 89f7093 into rails:master Jan 12, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jkowens jkowens deleted the jkowens:fix-null-byte branch Jan 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.