Join GitHub today
Prevent static middleware from attempting to serve a request with a null byte #23035
File paths cannot contain null byte characters and methods that do file path operations such as
By implementing this change the Static middleware will delegate serving the request to the application stack instead of raising an error and responding with a 500 status. Resolves #22235.
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.