New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] Improve Action Cable configuration explanations #23096

Merged
merged 1 commit into from Jan 18, 2016

Conversation

Projects
None yet
6 participants
@HayleyCAnderson
Contributor

HayleyCAnderson commented Jan 18, 2016

  • Clarify wording around how defaults work
  • Clarify wording around what formatting versus information is required
  • Separate consumer configuration section since it is important and wordy
  • Add additional explanation of options for setting consumer configuration
  • Consolidate consumer configuration information to reduce confusion
Improve Action Cable configuration explanations
* Clarify wording around how defaults work
* Clarify wording around what formatting versus information is required
* Separate consumer configuration section since it is important and wordy
* Add additional explanation of options for setting consumer configuration
* Consolidate consumer configuration information to reduce confusion
@rails-bot

This comment has been minimized.

rails-bot commented Jan 18, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@maclover7

This comment has been minimized.

Member

maclover7 commented Jan 18, 2016

👍 Thank you for your contribution!

maclover7 added a commit that referenced this pull request Jan 18, 2016

Merge pull request #23096 from HayleyCAnderson/ha-action-cable-docs
[ci skip] Improve Action Cable configuration explanations

@maclover7 maclover7 merged commit d95d680 into rails:master Jan 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@maclover7

This comment has been minimized.

Member

maclover7 commented Jan 18, 2016

❤️ 💚 💙 💛 💜

@edward

This comment has been minimized.

Contributor

edward commented Jan 24, 2016

@HayleyCAnderson nice work here – love to see doc contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment