New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing source_type if provided on hmt which belongs to an sti re… #23221

Merged
merged 1 commit into from Jan 24, 2016

Conversation

Projects
None yet
4 participants
@vipulnsward
Member

vipulnsward commented Jan 24, 2016

…cord

Fixes #23209

Specs coming up, trying to reuse existing ones.

@vipulnsward vipulnsward force-pushed the vipulnsward:23209-fix-missin_source_type branch Jan 24, 2016

@vipulnsward vipulnsward force-pushed the vipulnsward:23209-fix-missin_source_type branch Jan 24, 2016

@vipulnsward

This comment has been minimized.

Member

vipulnsward commented Jan 24, 2016

Done.

@vipulnsward vipulnsward force-pushed the vipulnsward:23209-fix-missin_source_type branch to b334bc9 Jan 24, 2016

rafaelfranca added a commit that referenced this pull request Jan 24, 2016

Merge pull request #23221 from vipulnsward/23209-fix-missin_source_type
Add missing source_type if provided on hmt which belongs to an sti re…

@rafaelfranca rafaelfranca merged commit 5119171 into rails:master Jan 24, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

rafaelfranca added a commit that referenced this pull request Jan 24, 2016

Merge pull request #23221 from vipulnsward/23209-fix-missin_source_type
Add missing source_type if provided on hmt which belongs to an sti re…
@rafaelfranca

This comment has been minimized.

Member

rafaelfranca commented Jan 24, 2016

Backported in c0a49ef

@heaven

This comment has been minimized.

heaven commented Jan 25, 2016

@vipulnsward hi, just noticed in the test case here vipulnsward@b334bc9#diff-a13fbc29998231c717b734d660117ebaR282 it only checks for assoc.size, which did pass before the fix too. In my example here: https://gist.github.com/heaven/55416bc2d2d51dfdb511 the test did fail on the assoc.count line (assoc.reload.size should fail too).

@vipulnsward vipulnsward deleted the vipulnsward:23209-fix-missin_source_type branch Jan 25, 2016

@vipulnsward

This comment has been minimized.

Member

vipulnsward commented Jan 25, 2016

Hi @heaven, it passes that too. But going to add test for it.

https://gist.github.com/vipulnsward/0cd9dfb9c98fc69b01f7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment