Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve mysqldump #23301
After we running
--- MySQL dump 10.13 Distrib 5.7.9, for osx10.9 (x86_64) +-- MySQL dump 10.13 Distrib 5.6.23, for osx10.10 (x86_64)
-) ENGINE=InnoDB DEFAULT CHARSET=utf8; +) ENGINE=InnoDB AUTO_INCREMENT=437 DEFAULT CHARSET=utf8;
Because default output of
In addition, after we running
--- Dump completed on 2016-01-28 13:34:00 +-- Dump completed on 2016-01-28 13:48:05
So, I added additional options to "mysqldump" command and I removed
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
I think if you skip-comments you dont need to
@jeremy I see skip-comments on 5.5 https://dev.mysql.com/doc/refman/5.5/en/mysqldump.html#option_mysqldump_dump-date and maria https://mariadb.com/kb/en/mariadb/mysqldump/