Use app namespace for framework tasks

[ryohashimoto]

By introducing Rake proxy, rake rails commands become rails rails commands (rails rails:template, rails rails:update etc.) .

For simplicity, I removed the rails namespace from the framework codes and docs. (and now we can use rails template, rails update etc.)

---

updated:

Not removing the rails namespace, use app namespace instead.
e.g. rails rails:template and rails rails:update tasks should be rails app:template, rails app:update

[rails-bot]

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[ryohashimoto]

In this file, only the namespace and indentations are changed.

[kaspth]

I don't think we should change this right now. I think more of bin/rails as the runner, and that the commands it runs pertains to the app itself... mostly. Because some commands fiddle more with the framework, i.e. those in the rails namespace. I say we keep it like this for 5.0 and spare the deprecation cycle. Thanks!

[matthewd]

@kaspth should we change the namespace to app: or something? rails rails:foo does look pretty terrible.

[ryohashimoto]

@matthewd
I think so too.
The rails namespace is used for multiple purposes (update and template). So we could remove the namespace or use another namespace.

[kaspth]

Yeah, app sounds good.

We should still define the rails versions but enrich them with a deprecation prerequisite task.

[ryohashimoto]

@kaspth
Thanks for reopening this PR.
I updated the PR to use app namespace and add deprecation warnings for existing tasks under the rails namespace.

[kaspth]

Needs more info. Mention some of the tasks and that the rails: namespace has been deprecated.

[kaspth]

Also needs a rebase (and remember to keep your commits squashed). Thanks ❤️

[ryohashimoto]

@kaspth
Thanks for your advice.
Modified to use ActiveSupport::Deprecation.warn and removed deprecated task in the rails namespace.
So, when the task in the rails namespace is executed, only a deprecation message is printed out.

[kaspth]

Sorry wasn't clear enough.

Don't need to print deprecation warnings for every task in the namespace.

I meant we shouldn't use Rake.application.top_level_tasks.grep(/^rails:/). I didn't mean to remove the deprecation enrichment of the rails: namespaced tasks, that part was correct before.

[kaspth]

We should replace this with:

task :deprecated do |task|
  ActiveSupport::Deprecation.warn(<<-MSG.squish)
    Running #{task.name.sub('deprecated:', '')} with the rails: namespace is deprecated in favor of app.
    Run e.g. bin/rails app:update instead."
  MSG
end

[ryohashimoto]

I modified the codes for the :rails namespace in my local environment.

namespace :rails do
  task :deprecated do |task|
    ActiveSupport::Deprecation.warn(<<-MSG.squish)
      Running #{task.name.sub('deprecated:', '')} with the rails: namespace is deprecated in favor of app.
      Run e.g. bin/rails app:update instead."
    MSG
  end

  task :update => ['deprecated', 'app:update']
  task :template => ['deprecated',  'app:template']

  namespace :templates do
    task :copy => ['deprecated', 'app:templates:copy']
  end

  namespace :update do
    task :configs => ['deprecated', 'app:update:configs']
    task :bin => ['deprecated', 'app:update:bin']
  end
end

and ran the command.

$ rails rails:update                                                                  1 ↵  
DEPRECATION WARNING: Running rails:deprecated with the rails: namespace is deprecated in favor of app. Run e.g. bin/rails app:update instead.". (called from block in execute at /Users/ryo/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-10.5.0/lib/rake/task.rb:238)

The message is incorrect because rails:deprecated isn't the original task used by the actual command.

[ryohashimoto]

The code

Rake.application.top_level_tasks

returns only task names given in a command. (e.g. when rails rails:update is given, only [rails:update] is returned, not all tasks in the rails: namespace.)

So, I think the below snippet is correct.

namespace :rails do
  task :deprecated do |task|
    Rake.application.top_level_tasks.grep(/^rails:/).each do |task|
      ActiveSupport::Deprecation.warn(<<-MSG.squish)
        Running #{task} with the rails: namespace is deprecated in favor of app.
        Run e.g. bin/rails #{task.sub(/^rails:/, 'app:')} instead."
      MSG
    end
  end

  task :update => ['deprecated', 'app:update']
  task :template => ['deprecated',  'app:template']

  namespace :templates do
    task :copy => ['deprecated', 'app:templates:copy']
  end

  namespace :update do
    task :configs => ['deprecated', 'app:update:configs']
    task :bin => ['deprecated', 'app:update:bin']
  end
end

[ryohashimoto]

OK, I understand.
I removed Rake.application.top_level_tasks.grep(/^rails:/)

[ryohashimoto]

Updated and rebased. I think it's better to use deprecated task names like below.
(And it doesn't deprecate all tasks with rails: namespace.)

namespace :rails do
  %i(update template templates:copy update:configs update:bin).each do |task_name|
    task "#{task_name}" do
      ActiveSupport::Deprecation.warn(<<-MSG.squish)
        Running #{task_name} with the rails: namespace is deprecated in favor of app.
        Run e.g. bin/rails app:#{task_name} instead."
      MSG
      Rake.application.invoke_task("app:#{task_name}")
    end
  end
end

[ryohashimoto]

@kaspth
Could you take a look?

[kaspth]

Looks good and thanks for your patience! Can you rebase? If not, I will do it tonight 😄

[kaspth]

Wait, what do you mean by "(And it doesn't deprecate all tasks with rails: namespace.)"?

[ryohashimoto]

@kaspth
Thanks for your support. Rebased now.

(And it doesn't deprecate all tasks with rails: namespace.)

I mean only tasks listed below are now deprecated. If someone add other tasks in the 'rails' namespace,
they shouldn't be deprecated because they don't have corresponding tasks in the 'app' namespace.
I believe this approach is natural.

%i(update template templates:copy update:configs update:bin) # in the rails namespace

[kaspth]

@ryohashimoto thanks!

[ryohashimoto]

@kaspth Thanks a lot !