Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove json gem dependency #23453

Merged
merged 1 commit into from Feb 3, 2016
Merged

Remove json gem dependency #23453

merged 1 commit into from Feb 3, 2016

Conversation

@mperham
Copy link
Contributor

@mperham mperham commented Feb 3, 2016

All modern Rubies ship JSON as part of stdlib. Using the gem actually hurts multi-platform support due to build difficulties on Windows.

All modern Rubies ship JSON as part of stdlib.  Using the gem actually hurts multi-platform support due to build difficulties on Windows.
rafaelfranca added a commit that referenced this pull request Feb 3, 2016
Remove json gem dependency
@rafaelfranca rafaelfranca merged commit 12bdda7 into rails:master Feb 3, 2016
@mperham mperham deleted the mperham:remove_json branch Feb 3, 2016
@sferik
Copy link
Contributor

@sferik sferik commented Feb 10, 2016

Thanks, @mperham! This is part II of #10576.

lucaspiller added a commit to ifad/ruote-postgres that referenced this pull request Apr 5, 2016
bdewater added a commit to bdewater/mollie-api-ruby that referenced this pull request Jul 4, 2016
All Ruby versions >= 1.9.3 include the JSON gem in the standard library, so this requirement is redundant. See rails/rails#23453

Also: Ruby 2.4 will be bundled with a ~> 2.0 version of JSON for compatibility with the unification of Fixnum and Bignum into Integer.
@betesh
Copy link
Contributor

@betesh betesh commented Mar 15, 2017

@mperham I know this is a little late, but this change actually led to some very undesirable behavior which I describe here: rubygems/bundler#5419

Could you explain what you mean by:

Using the gem actually hurts multi-platform support due to build difficulties on Windows.

Given the issue I describe in the ticket linked above--that you could end up with a different version of json in test then in production--are these build difficulties a reasonable trade-off?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.