New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove json gem dependency #23453

Merged
merged 1 commit into from Feb 3, 2016

Conversation

Projects
None yet
5 participants
@mperham
Contributor

mperham commented Feb 3, 2016

All modern Rubies ship JSON as part of stdlib. Using the gem actually hurts multi-platform support due to build difficulties on Windows.

Remove json gem dependency
All modern Rubies ship JSON as part of stdlib.  Using the gem actually hurts multi-platform support due to build difficulties on Windows.

rafaelfranca added a commit that referenced this pull request Feb 3, 2016

@rafaelfranca rafaelfranca merged commit 12bdda7 into rails:master Feb 3, 2016

@mperham mperham deleted the mperham:remove_json branch Feb 3, 2016

@beanieboi beanieboi referenced this pull request in colszowka/simplecov Feb 5, 2016

Open

dropping json gem dependency #458

@ahacop ahacop referenced this pull request in stripe/stripe-ruby Feb 9, 2016

Merged

Remove json gem dependency #379

@sferik

This comment has been minimized.

Show comment
Hide comment
@sferik

sferik Feb 10, 2016

Contributor

Thanks, @mperham! This is part II of #10576.

Contributor

sferik commented Feb 10, 2016

Thanks, @mperham! This is part II of #10576.

@u2 u2 referenced this pull request in ruby-grape/grape-entity Feb 12, 2016

Closed

kill multi_json Dependencies #209

@mikz mikz referenced this pull request in bugsnag/bugsnag-ruby Feb 19, 2016

Closed

Drop json gem dependency #278

@deepj deepj referenced this pull request in jnunemaker/httparty Feb 22, 2016

Merged

Remove json gem #464

@yob yob referenced this pull request in google/google-api-ruby-client Feb 25, 2016

Merged

replace multi_json dependency with regular stdlib JSON #368

@mperham mperham referenced this pull request in hanami/hanami Mar 3, 2016

Closed

Can't load json or json_pure #512

lucaspiller added a commit to ifad/ruote-postgres that referenced this pull request Apr 5, 2016

@BenMorganIO BenMorganIO referenced this pull request in colszowka/simplecov Apr 13, 2016

Closed

remove json runtime dependency #491

@andrew andrew referenced this pull request in domcleal/spdx-licenses Apr 14, 2016

Merged

Removed json gem dependency #4

@develar develar referenced this pull request in jordansissel/fpm May 7, 2016

Open

Self-contained fpm #1103

bdewater added a commit to bdewater/mollie-api-ruby that referenced this pull request Jul 4, 2016

Remove JSON dependency
All Ruby versions >= 1.9.3 include the JSON gem in the standard library, so this requirement is redundant. See rails/rails#23453

Also: Ruby 2.4 will be bundled with a ~> 2.0 version of JSON for compatibility with the unification of Fixnum and Bignum into Integer.

@bdewater bdewater referenced this pull request in mollie/mollie-api-ruby Jul 4, 2016

Closed

Remove JSON dependency #29

@sethherr sethherr referenced this pull request in papertrail/papertrail-cli Nov 21, 2016

Merged

Stop using okjson #82

@bf4 bf4 referenced this pull request in rails-api/active_model_serializers Jan 24, 2017

Merged

Fix JRuby build on CI, with a suggestion from Travis CI support #2040

@betesh

This comment has been minimized.

Show comment
Hide comment
@betesh

betesh Mar 15, 2017

Contributor

@mperham I know this is a little late, but this change actually led to some very undesirable behavior which I describe here: bundler/bundler#5419

Could you explain what you mean by:

Using the gem actually hurts multi-platform support due to build difficulties on Windows.

Given the issue I describe in the ticket linked above--that you could end up with a different version of json in test then in production--are these build difficulties a reasonable trade-off?

Contributor

betesh commented Mar 15, 2017

@mperham I know this is a little late, but this change actually led to some very undesirable behavior which I describe here: bundler/bundler#5419

Could you explain what you mean by:

Using the gem actually hurts multi-platform support due to build difficulties on Windows.

Given the issue I describe in the ticket linked above--that you could end up with a different version of json in test then in production--are these build difficulties a reasonable trade-off?

@jhawthorn jhawthorn referenced this pull request in leshill/handlebars_assets May 7, 2017

Merged

Remove dependency on json, multi_json #158

@yuki24 yuki24 referenced this pull request in spacialdb/fcm May 30, 2017

Merged

Drop json dependency #26

@yuki24 yuki24 referenced this pull request in arsduo/koala Jul 28, 2017

Open

Remove json gem dependency #616

2 of 2 tasks complete

@yuki24 yuki24 referenced this pull request in lfittl/pg_query Nov 10, 2017

Merged

Drop JSON dependency #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment