Constrain the number of unused connections kept in the pool #23815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just as we don't fill the pool with connections at boot, we generally needn't maintain a full pool just because we once needed that many. For maximum compatibility, this behaviour is disabled by default, by setting the minimum to match the configured maximum. But by choosing to configure a lower minimum, and setting a suitable reaping_frequency (e.g., 10 minutes), you can now get a dynamic pool that keeps just what it is likely to need in the near future.
| @@ -328,6 +332,8 @@ def initialize(spec) | |||
|
|
|||
| # default max pool size to 5 | |||
| @size = (spec.config[:pool] && spec.config[:pool].to_i) || 5 | |||
| @minimum_size = (spec.config[:pool_minimum] && spec.config[:pool_minimum].to_i) || @size | |||
There was a problem hiding this comment.
I think we should check and raise if @minimum_size > @size.
|
Addressed by #31221 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just as we don't fill the pool with connections at boot, we generally needn't maintain a full pool just because we once needed that many.
For maximum compatibility, this behaviour is disabled by default, by setting the minimum to match the configured maximum. But by choosing to configure a lower minimum, and setting a suitable
reaping_frequency(e.g., 10 minutes), you can now get a dynamic pool that keeps just what it is likely to need in the near future.@thedarkone I'm pretty sure this is terrible 馃槙