Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise #23717 (Add "Rendering ..." message) using proper ActiveSupport::LogSubscriber#start #23915

Merged
merged 3 commits into from Feb 26, 2016

Conversation

@sikachu
Copy link
Member

@sikachu sikachu commented Feb 26, 2016

I revise #23717 by defining #start method instead of instrument another event.

r? @rafaelfranca

vipulnsward and others added 3 commits Feb 16, 2016
… that we have started to render something, at the very beginning.

This helps to easily identify queries from controller vs views

Fixes #23710
We don't need to instrument another event as
`ActiveSupport::LogSubscriber` already tracks when the instrumentation
starts.

Close #23717
@sikachu sikachu added this to the 5.0.0 milestone Feb 26, 2016
rafaelfranca added a commit that referenced this pull request Feb 26, 2016
Revise #23717 (Add "Rendering ..." message) using proper ActiveSupport::LogSubscriber#start
@rafaelfranca rafaelfranca merged commit bf1ac69 into rails:master Feb 26, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants