New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise #23717 (Add "Rendering ..." message) using proper ActiveSupport::LogSubscriber#start #23915

Merged
merged 3 commits into from Feb 26, 2016

Conversation

Projects
None yet
3 participants
@sikachu
Member

sikachu commented Feb 26, 2016

I revise #23717 by defining #start method instead of instrument another event.

r? @rafaelfranca

vipulnsward and others added some commits Feb 16, 2016

Added log "Rendering ...", when starting to render a template, to log…
… that we have started to render something, at the very beginning.

This helps to easily identify queries from controller vs views

Fixes #23710
Update to use Subscriber#start instead
We don't need to instrument another event as
`ActiveSupport::LogSubscriber` already tracks when the instrumentation
starts.

Close #23717

@sikachu sikachu added the actionview label Feb 26, 2016

@sikachu sikachu added this to the 5.0.0 milestone Feb 26, 2016

rafaelfranca added a commit that referenced this pull request Feb 26, 2016

Merge pull request #23915 from sikachu/pr-23710-update
Revise #23717 (Add "Rendering ..." message) using proper ActiveSupport::LogSubscriber#start

@rafaelfranca rafaelfranca merged commit bf1ac69 into rails:master Feb 26, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment